fix(store): use Object.create(null) for plain lookup maps to prevent prototype pollution#2446
Merged
Conversation
…prototype pollution
Objects used as string-keyed dictionaries (state names, action types, status
strings) were initialized with `{}`, inheriting Object.prototype. A key
matching an inherited property (e.g. `constructor`, `hasOwnProperty`) would
return a truthy prototype value instead of `undefined`, causing silent
mismatch in lookups.
Replaced all such maps with Object.create(null) in:
- `ɵensureStoreMetadata` — actions map keyed by action type
- `StateFactory._statesByName` / `_statePaths`
- `buildGraph`, `nameToState`, `findFullParentPath`, `topologicalSort` in internals.ts
- `createAllowedActionTypesMap` / `createAllowedStatusesMap` in of-action.ts
|
View your CI Pipeline Execution ↗ for commit 545462c
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
arturovt
requested review from
Carniatto,
joaqcid,
kuncevic,
markwhitfeld,
poloagustin and
splincode
as code owners
BundleMonFiles updated (2)
Unchanged files (4)
Total files change +153B +0.09% Groups updated (1)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (1)
Total files change +11B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects used as string-keyed dictionaries (state names, action types, status strings) were initialized with
{}, inheriting Object.prototype. A key matching an inherited property (e.g.constructor,hasOwnProperty) would return a truthy prototype value instead ofundefined, causing silent mismatch in lookups.Replaced all such maps with Object.create(null) in:
ɵensureStoreMetadata— actions map keyed by action typeStateFactory._statesByName/_statePathsbuildGraph,nameToState,findFullParentPath,topologicalSortin internals.tscreateAllowedActionTypesMap/createAllowedStatusesMapin of-action.ts