-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Feat: Add UnifiedPush support #16526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
p1gp1g
wants to merge
30
commits into
nextcloud:master
Choose a base branch
from
p1gp1g:feat/unifiedpush
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
3374962
chore(deps): Restrict jitpack content
p1gp1g c70655d
chore: Fix capability update
p1gp1g a4dc493
chore(notif): Support delete-multiple use dedicated function to handl…
p1gp1g 02e0c65
feat(unifiedpush): Add UnifiedPush service
p1gp1g 126f9bb
feat(unifiedpush): Add settings to enable UnifiedPush
p1gp1g 9bed2fe
feat(unifiedpush): Register web push and proxy push on startup
p1gp1g eb2a814
feat(unifiedpush): Unregister UnifiedPush/web push when needed
p1gp1g 9c5e10a
feat(unifiedpush): Do not register for talk notif if installed
p1gp1g e02820b
feat(unifiedpush): Allow selecting another distrib
p1gp1g 2d6c8ed
feat(unifiedpush): Show UnifiedPush settings only if a service is ava…
p1gp1g 482f035
feat(webpush): Fix appTypes name
p1gp1g 622b06d
feat(unifiedpush): Clarify object and function names
p1gp1g 244be55
feat(unifiedpush): Fix preference when dismissed
p1gp1g 51f7d57
feat(unifiedpush): Show introduction dialog if the user needs to pick…
p1gp1g 49d293e
feat(unifiedpush): Enable UnifiedPush by default for generic flavor
p1gp1g 447a785
feat(unifiedpush): Use worker to process UnifiedPush events
p1gp1g 116688e
feat(unifiedpush): Fix dialog by running in the UI thread
p1gp1g 8489d3d
feat(unifiedpush): Show notification to ask user to open the app on u…
p1gp1g 68e6013
feat(unifiedpush): Fix missing nextcloud talk pkg name
p1gp1g 8ac264a
Update gradle-verification
p1gp1g 03662fa
Lint
p1gp1g 630d3da
Fix SPDX headers
p1gp1g 8e52bc8
Use a single function to register/activate/unregister Web Push
p1gp1g 0296495
Use when to clarify handlePushMessage
p1gp1g de4ff8c
Move WebPushJobData to its own file
p1gp1g 0928c31
Use push parallel jobs within superviserScope
p1gp1g df811e5
Use TimeoutScope to avoid resource leak
p1gp1g 5960917
Logs with Log_OC on push event
p1gp1g 3eb072a
Move Settings' push category to its own file
p1gp1g 2f1feb2
Add function to get NextcloudClient
p1gp1g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
deleteLocalDataneeds to be true forUnregisterAccountDeviceForProxyOperation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleteLocalDatamay not be the best name. It describes "delete user public key, and unsubscribe from the proxy".The idea is that we can unregister for proxy push notifications in 3 cases:
In the first and last case, we want either to wipe our current keys, and unregister on the proxy. In the 2nd case, that may simply be temporary, we don't need/want to unsubscribe