Add Consul interdomain example#6517
Closed
anastasia-malysheva wants to merge 12 commits intonetworkservicemesh:mainfrom
Closed
Add Consul interdomain example#6517anastasia-malysheva wants to merge 12 commits intonetworkservicemesh:mainfrom
anastasia-malysheva wants to merge 12 commits intonetworkservicemesh:mainfrom
Conversation
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
…mples to the example directory; replaced path to the absoluter references Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
… into add-consul-example
denis-tingaikin
requested review from
NikitaSkrynnik,
ThetaDR,
edwarnicke,
fkautz and
glazychev-art
| kubectl --kubeconfig=$KUBECONFIG1 exec -it alpine-nsc -- curl 172.16.1.2:8080 | ||
| ``` | ||
|
|
||
| You should see "hello world" answer. |
Contributor
There was a problem hiding this comment.
Probably we need to add a bash command to verify the connection, like here:
https://github.com/networkservicemesh/deployments-k8s/blob/main/examples/nsm_istio/README.md?plain=1#L56-L58
Member
There was a problem hiding this comment.
I think we need to use something with UI than just 'hello world' for demo.
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Contributor
Author
|
I'm close this PR as soon as Marina Shustowa came back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request inherits from #6490 and adding some updates.
Signed-off-by: anastasia.malysheva anastasia.malysheva@xored.com