Add support for SSH certificate file in Node class#973
Open
rnwolfe wants to merge 6 commits intonetenglabs:developfrom
Open
Add support for SSH certificate file in Node class#973rnwolfe wants to merge 6 commits intonetenglabs:developfrom
rnwolfe wants to merge 6 commits intonetenglabs:developfrom
Conversation
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
Author
|
I had rebased my PR on top of #974, so may need to do some git-fu here before merge. The latest change in rnwolfe@6922031 does fix by removing pvt key handling and offloading that to the asyncssh logic which handles it more robustly. This worked in my environment with ~9 cert-based auth linux nodes. |
- Remove direct handling of SSH key and passphrase decrypt for both primary and jump host connections - Move ssh key and passphrase handling to asynchssh - Update asyncssh options configuration for more flexible SSH authentication
rnwolfe
force-pushed
the
bug/972-cert-auth
branch
from
6922031 to
7e212e9
Compare
Author
|
I ran pytest signed my last commit, but with the other commits I pulled in, I couldn't sign my prior one. I also now added multiple versions of myself to the history. Whoops! Let me know if I should do anything clean this up. |
ddutt
approved these changes
May 6, 2025
LucaNicosia
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i will fill this out further, but wanted to open PR for viewing outside of myself
Test inclusion requirements
In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:
For additional information about tests, follow this link
Related Issue
Fixes #972
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Adds support for cert-based ssh auth
New Behavior
...
Contrast to Current Behavior
...
Discussion: Benefits and Drawbacks
...
Changes to the Documentation
...
Proposed Release Note Entry
...
Comments
Include additional comments about the this pull request
Double Check
developbranch.developbranch.--signoffapplied