feat: replace api key with oauth2#24
Merged
leoparente merged 9 commits intoupdate_datamodelfrom Apr 17, 2025
Merged
Conversation
|
Go test coverage
Total coverage: 92.6% |
jajeffries
reviewed
Apr 17, 2025
jajeffries
approved these changes
Apr 17, 2025
jajeffries
approved these changes
Apr 17, 2025
mfiedorowicz
approved these changes
Apr 17, 2025
Member
mfiedorowicz
left a comment
There was a problem hiding this comment.
LGTM 🙇 , one cov related question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the Diode SDK by replacing API key-based authentication with OAuth2 client credentials. The most important changes include updating environment variables, modifying the client structure and methods, and updating tests to reflect these changes.
Authentication Changes:
README.md: Updated environment variables to includeDIODE_CLIENT_IDandDIODE_CLIENT_SECRETfor OAuth2 authentication.diode/client.go: RemovedDIODE_API_KEYand addedDIODE_CLIENT_IDandDIODE_CLIENT_SECRETenvironment variables.diode/client.go: ReplacedgetAPIKeyfunction withgetClientIDandgetClientSecretfunctions to retrieve OAuth2 credentials.diode/client.go: AddeddiodeAuthenticationstruct and methods to handle OAuth2 token fetching and updating client metadata.Client Structure Changes:
diode/client.go: UpdatedGRPCClientstruct to includeclientIDandclientSecretfields instead ofapiKey.diode/client.go: ModifiedNewClientfunction to initializeclientIDandclientSecretinstead ofapiKey.Test Updates:
diode/client_test.go: Updated tests to reflect the changes from API key to OAuth2 client credentials. This includes modifying test cases to useclientIDandclientSecret. [1] [2] [3] [4] [5] [6] [7]Example Update:
examples/main.go: Updated example usage to includeWithClientIDandWithClientSecretinstead ofWithAPIKey.