Adding rule for for MTU validations#586
Open
juarocha wants to merge 15 commits intonetascode:developfrom
Open
Conversation
Collaborator
|
@juarocha I spent some time testing this today and it looks good but I think we still have some work to do to map this all the way through to the module. If I have the following interface in my data model: - name: Ethernet1/16
mode: trunk
description: "NAC_INT Trunk PO Member Interface"
enabled: true
mtu: 9000
speed: 10gb
duplex: fullYour rule will catch it and tell me to set the mtu to "msg": "Invalid parameters in playbook: while processing interface Ethernet1/16, 9216 : Invalid choice [ 9216 ] provided for param [ mtu ]"I think we might need to map this to Update: Never mind. This is not an issue. I was testing in my branch that does not have your changes. |
8c7e30f to
01b4314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Resolves #470
Related Collection Role
Related Data Model Element
Proposed Changes
Validation script for:
Test Notes
Cisco NDFC Version
12.2.3
Checklist