chore: v14.0.0 release#3973
Open
kamilmysliwiec wants to merge 23 commits into
Open
Conversation
When subscriptions are configured with an explicit path (for example
`subscriptions: { 'graphql-ws': { path: '/graphql' } }`) alongside `useGlobalPrefix: true`,
the apollo driver previously passed that path straight through to GqlSubscriptionService
without prefixing it. The HTTP endpoint resolved to `/api/graphql` while the websocket
bound to `/graphql`, so client upgrades targeting the prefixed URL were rejected.
Apply the application's global prefix to user-supplied `graphql-ws` and
`subscriptions-transport-ws` paths in `mergeDefaultOptions`. Boolean shorthand
(`'graphql-ws': true`) is preserved as-is because the existing fall-through already uses
the prefixed `options.path`. Mercurius is unaffected because its subscription transport
reuses the mercurius route path which is already prefixed.
Closes #2477
…tional-dts fix(@nestjs/graphql): keep resolvers required when skipping args
…lobal-prefix fix(apollo): respect useGlobalPrefix on custom subscription path
…ed-fields fix(graphql,apollo): ensures extensions are added to resolved fields
…nfo-nullable fix(graphql): change info to nullable
…port-ws Chore/remove subscriptions transport ws
chore: remove apollo playground
chore: migrate to esm
The build-time SDL emitted via autoSchemaFile in federation mode was written using graphql's default printSchema, which strips @key, @external, @extends, @requires and @provides. The runtime _service.sdl query was unaffected. GraphQLSchemaBuilder.generateSchema now accepts an optional printer; the federation factory passes printSchemaWithDirectives (subgraph v2+) or printSubgraphSchema (v1), matching the existing runtime selection. Closes #3722
# Conflicts: # packages/graphql/lib/schema-builder/factories/interface-definition.factory.ts # packages/graphql/lib/schema-builder/factories/object-type-definition.factory.ts # packages/graphql/lib/schema-builder/factories/union-definition.factory.ts # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information