fix(artifacts): tolerate unknown protobuf fields in artifact server#6053
Open
xingzihai wants to merge 1 commit intonektos:masterfrom
Open
fix(artifacts): tolerate unknown protobuf fields in artifact server#6053xingzihai wants to merge 1 commit intonektos:masterfrom
xingzihai wants to merge 1 commit intonektos:masterfrom
Conversation
Use protojson.UnmarshalOptions{DiscardUnknown: true} to parse protobuf
messages from GitHub Actions clients. This makes the artifact server
forward-compatible with new fields added by GitHub, such as the mime_type
field introduced in upload-artifact@v7.
Fixes nektos#6022
bkero
added a commit
to bkero/external-dns-docker
that referenced
this pull request
Apr 9, 2026
actions/upload-artifact v5+ sends a `mime_type` protobuf field that act's built-in artifact server cannot decode (nektos/act#6022). The fix PR (nektos/act#6053) is still unmerged, so pin to v4 — the last major that works under local act — until upstream lands the fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes artifact server compatibility with
upload-artifact@v7by tolerating unknown protobuf fields.Problem
When using
upload-artifact@v7, act's artifact server fails with:GitHub added a new
mime_typefield to theCreateArtifactRequestprotobuf message, but act's protobuf definition doesn't include this field.protojson.Unmarshal()uses strict mode by default, rejecting unknown fields.Solution
Modified
parseProtbufBodyfunction inpkg/artifacts/artifacts_v4.go:Using
DiscardUnknown: truemakes the artifact server forward-compatible with new fields added by GitHub.Changes
pkg/artifacts/artifacts_v4.go(1 line)Fixes #6022