Skip to content

fix: Cannot find module MODULE_NOT_FOUND error handling #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xingzihai wants to merge 1 commit into
base: master
Choose a base branch
from
+34 −0
Open

fix: Cannot find module MODULE_NOT_FOUND error handling #6049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions pkg/runner/action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,18 @@ func runActionImpl(step actionStep, actionDir string, remoteAction *remoteAction
if err := maybeCopyToActionDir(ctx, step, actionDir, actionPath, containerActionDir); err != nil {
return err
}

// Check if the main file exists in the local action directory
mainFilePath := filepath.Join(actionDir, actionPath, action.Runs.Main)
if _, err := os.Stat(mainFilePath); os.IsNotExist(err) {
// Check if package.json exists to provide build suggestion
packageJsonPath := filepath.Join(actionDir, actionPath, "package.json")
if _, pkgErr := os.Stat(packageJsonPath); pkgErr == nil {
return fmt.Errorf("the action '%s' is missing the required main file '%s'. This is likely because the action was built with TypeScript/JavaScript and the 'dist/' folder was not included in the git repository (excluded by .gitignore). Please build the action by running 'npm install && npm run build' in the action directory '%s', or contact the action maintainer to include the pre-built files in the release", stepModel.Uses, action.Runs.Main, filepath.Join(actionDir, actionPath))
}
return fmt.Errorf("the action '%s' is missing the required main file '%s'. Please check the action's action.yml file and ensure the file exists", stepModel.Uses, action.Runs.Main)
}

containerArgs := []string{rc.GetNodeToolFullPath(ctx), path.Join(containerActionDir, action.Runs.Main)}
logger.Debugf("executing remote job container: %s", containerArgs)

Expand Down Expand Up @@ -555,6 +567,17 @@ func runPreStep(step actionStep) common.Executor {
return err
}

// Check if the pre script file exists in the local action directory
preFilePath := filepath.Join(actionDir, actionPath, action.Runs.Pre)
if _, err := os.Stat(preFilePath); os.IsNotExist(err) {
// Check if package.json exists to provide build suggestion
packageJsonPath := filepath.Join(actionDir, actionPath, "package.json")
if _, pkgErr := os.Stat(packageJsonPath); pkgErr == nil {
return fmt.Errorf("the action '%s' is missing the required pre script file '%s'. This is likely because the action was built with TypeScript/JavaScript and the 'dist/' folder was not included in the git repository (excluded by .gitignore). Please build the action by running 'npm install && npm run build' in the action directory '%s', or contact the action maintainer to include the pre-built files in the release", stepModel.Uses, action.Runs.Pre, filepath.Join(actionDir, actionPath))
}
return fmt.Errorf("the action '%s' is missing the required pre script file '%s'. Please check the action's action.yml file and ensure the file exists", stepModel.Uses, action.Runs.Pre)
}

containerArgs := []string{rc.GetNodeToolFullPath(ctx), path.Join(containerActionDir, action.Runs.Pre)}
logger.Debugf("executing remote job container: %s", containerArgs)

Expand Down Expand Up @@ -658,6 +681,17 @@ func runPostStep(step actionStep) common.Executor {
populateEnvsFromSavedState(step.getEnv(), step, rc)
populateEnvsFromInput(ctx, step.getEnv(), step.getActionModel(), rc)

// Check if the post script file exists in the local action directory
postFilePath := filepath.Join(actionDir, actionPath, action.Runs.Post)
if _, err := os.Stat(postFilePath); os.IsNotExist(err) {
// Check if package.json exists to provide build suggestion
packageJsonPath := filepath.Join(actionDir, actionPath, "package.json")
if _, pkgErr := os.Stat(packageJsonPath); pkgErr == nil {
return fmt.Errorf("the action '%s' is missing the required post script file '%s'. This is likely because the action was built with TypeScript/JavaScript and the 'dist/' folder was not included in the git repository (excluded by .gitignore). Please build the action by running 'npm install && npm run build' in the action directory '%s', or contact the action maintainer to include the pre-built files in the release", stepModel.Uses, action.Runs.Post, filepath.Join(actionDir, actionPath))
}
return fmt.Errorf("the action '%s' is missing the required post script file '%s'. Please check the action's action.yml file and ensure the file exists", stepModel.Uses, action.Runs.Post)
}

containerArgs := []string{rc.GetNodeToolFullPath(ctx), path.Join(containerActionDir, action.Runs.Post)}
logger.Debugf("executing remote job container: %s", containerArgs)

Expand Down