add --lenient-env-parsing flag, so new lines are treated as continuation from the env var, and not discarded with error.#6045
Conversation
…ation from the env var, and not discarded with error.
|
If act has different behaviour from GitHub then I would say that is a bug and it should be fixed rather than creating a new CLI option. Is this something that changed in GHA? |
|
Yes, i agree. I just didnt know if that behaviour was on purpose, but yes, it parses differently from github. Ive changed so it will parse like this by default, without flag. What do you think about that? Thanks for the attention. |
|
If that helps, using this project: https://github.com/ChristopherHX/runner.server works for me, confirming that act actually parses the ENV vars differently from github. |
|
I was not even aware of this feature, so I missed this detail as well in the parsing function. :) I always expected that only heredoc style is possible for multine. Not adding a cli option is good then |
|
I think we still need a test for this feature, to ensure that this works as expected |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6045 +/- ##
==========================================
+ Coverage 74.65% 76.96% +2.30%
==========================================
Files 73 74 +1
Lines 11139 9321 -1818
==========================================
- Hits 8316 7174 -1142
+ Misses 2186 1506 -680
- Partials 637 641 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
done |
|
Looks good so far, thanks. Checking this later myself against GitHubs behavior to double ckeck. |
When running act locally with an action like ORT environment variables are not preserved between steps; eg.
analyzer,evaluator, because act parsing of environment variables seems to be even stricter than GHA's, so my action just fails locally, although it does not fail in GitHub actioins itself. I added this flag so this more lenient parsing is optional.