Skip to content

fix: discard unknown fields in protobuf unmarshal for artifact v4 API #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
majiayu000 wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −1
Open

fix: discard unknown fields in protobuf unmarshal for artifact v4 API #6039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9879b5b
fix: discard unknown fields in protobuf unmarshal for artifact v4 API
majiayu000 Mar 25, 2026
7e5e42b
test: add unit test for v4 CreateArtifact with unknown fields
majiayu000 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/artifacts/artifacts_v4.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ func (r *artifactV4Routes) parseProtbufBody(ctx *ArtifactContext, req protorefle
ctx.Error(http.StatusInternalServerError, "Error decode request body")
return false
}
err = protojson.Unmarshal(body, req)
err = protojson.UnmarshalOptions{DiscardUnknown: true}.Unmarshal(body, req)
if err != nil {
log.Errorf("Error decode request body: %v", err)
ctx.Error(http.StatusInternalServerError, "Error decode request body")
Expand Down
18 changes: 18 additions & 0 deletions pkg/artifacts/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,24 @@ func runTestJobFile(ctx context.Context, t *testing.T, tjfi TestJobFileInfo) {
})
}

func TestCreateArtifactV4UnknownField(t *testing.T) {
assert := assert.New(t)

var memfs = fstest.MapFS(map[string]*fstest.MapFile{})

router := httprouter.New()
RoutesV4(router, "artifact/server/path", writeMapFS{memfs}, memfs)

// Simulate upload-artifact@v7 sending an unknown field (mime_type)
body := `{"workflow_run_backend_id":"1","workflow_job_run_backend_id":"2","name":"test-artifact","version":4,"mime_type":"application/zip"}`
req, _ := http.NewRequest("POST", "http://localhost"+path.Join(ArtifactV4RouteBase, "CreateArtifact"), strings.NewReader(body))
rr := httptest.NewRecorder()

router.ServeHTTP(rr, req)

assert.Equal(http.StatusOK, rr.Code, "CreateArtifact should succeed even with unknown fields like mime_type")
}

func TestMkdirFsImplSafeResolve(t *testing.T) {
baseDir := "/foo/bar"

Expand Down