Skip to content

Continued work on GC App Settings#936

Closed
jeffkala wants to merge 50 commits intogc-app-settingsfrom
jlk-gc-app-settings
Closed

Continued work on GC App Settings#936
jeffkala wants to merge 50 commits intogc-app-settingsfrom
jlk-gc-app-settings

Conversation

@jeffkala
Copy link
Copy Markdown
Contributor

@jeffkala jeffkala commented May 13, 2025

Closes: #

What's Changed

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

gsnider2195 and others added 30 commits April 2, 2025 11:56
@gsnider2195
Fixed copy button not hidden on diff tab in generate intended config …
edabf2f 
…tool. (#905)
@itdependsnetworks
Added tests to ensure that mkdocs release notes are properly set. (#898)
7ea2d11 
Added tests to ensure that mkdocs release notes are properly set and fixed other tests issues
@itdependsnetworks
Add testing for the two issues with mkdocs versus markdown rendering … (
295370f 
#921)

* Add testing for the two issues with mkdocs versus markdown rendering and associated fixes.
@itdependsnetworks
Fixed copy button not working on detail views (#924)
fe17bd5
@jeffkala
Fix 794 issue with repo syncs with multiple platforms using same netw…
e78a64d 
…ork drivers (#925)
@jeffkala
initial fix for 906 unable to deploy in 2.4.0 (#926)
b21a4f3 
* initial fix for 906 unable to deploy in 2.4.0
@mattmiller87 @jeffkala
Release v2.4.1a1
b4bc518
@jeffkala
Release v2.4.1
b38fe22
@jeffkala
Merge pull request #928 from nautobot/release/2.4.1a1
20f5f3d 
Release 2.4.1
@jeffkala
Bump version
418e03c
@itdependsnetworks
Merge pull request #934 from nautobot/release-2.4.1-to-develop
fe24e14 
Release 2.4.1 to develop
@nautobot-bot @smk4664
Cookie updated by NetworkToCode Cookie Drift Manager Tool (#927)
48ee70e 
* Cookie updated by NetworkToCode Cookie Drift Manager Tool

Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.5.0",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-app-golden-config.git",
    "path": "/tmp/tmpn7c5gn0b/nautobot-app-golden-config",
    "repository_path": "/tmp/tmpn7c5gn0b/nautobot-app-golden-config",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@itdependsnetworks @jeffkala @nkallergis",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_golden_config",
        "verbose_name": "Golden Config",
        "app_slug": "nautobot-golden-config",
        "project_slug": "nautobot-app-golden-config",
        "repo_url": "https://github.com/nautobot/nautobot-app-golden-config",
        "base_url": "golden-config",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotGoldenConfig",
        "project_short_description": "An app for configuration on nautobot",
        "model_class_name": "ComplianceFeature",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/golden-config/en/latest",
        "_extensions": [
            "local_extensions.camel_case_to_kebab",
            "local_extensions.camel_case_to_words"
        ],
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpn7c5gn0b",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.5.0"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.RUFF",
        "PostAction.POETRY"
    ],
    "baked_commit_ref": "cc1a95931455ed52b0a30b22257e5c8fbdcd212d",
    "draft": false
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.5.0",
    "pull_request": null,
    "post_action": [
        "ruff",
        "poetry"
    ],
    "disable_post_actions": true,
    "draft": false
}
```

* Revert unnecessary changes. Fix docs warnings and lock packages.

* Remove Intended Repository Matching Rule

This section that the documentation is rerfering to was removed in PR 205.

* Revert minimum test version change.

---------

Co-authored-by: bakebot <info@networktocode.com>
Co-authored-by: Stephen Kiely <stephenkiely87@gmail.com>
@joewesch @itdependsnetworks
Changing the settings form to use dynamic dropdowns (#916)
85cc758 
* Changes the settings form to dynamic dropdown

---------

Co-authored-by: itdependsnetworks <ken@celenza.org>
@jeffkala
sync in develop
51e8e49
@jeffkala
renumber error codes after develop merge
1375958
@robertoduarte-codilime
Fix relative path resolution for Jinja templates when rendering (#935)
1bc1b24
@jeffkala
initial working gc settings
ada0e03
@jeffkala
Change for loop to DB query for device to settings map (#941)
39d4876 
* implement more performance query

* remove test logging

* add a few more unittest
@jeffkala
start working through new settings methods
f8557cd
@jeffkala
merge in develop
fc9df61
@jeffkala
another pass of new implementation
6ff5e4d
@jeffkala
more updates
58f7237
@jeffkala
all jobs working poc1
780488e
@jtdub
initial stab at upgrading hier config in golden config
a99998b
@jtdub
ruff check
388a924
@jtdub
change remediatin_config to property.
09de272
@jtdub
pylint
157662b
@jtdub
set remediation_options variable
779b665
@jtdub
add remediation tests
7e3bf52
@jtdub
pylint
eb7e733
itdependsnetworks and others added 20 commits June 26, 2025 19:45
@itdependsnetworks @jtdub
Added tests to ensure that mkdocs release notes are properly set. (#898)
315adab 
Added tests to ensure that mkdocs release notes are properly set and fixed other tests issues
@itdependsnetworks @jtdub
Add testing for the two issues with mkdocs versus markdown rendering … (
3b84708 
#921)

* Add testing for the two issues with mkdocs versus markdown rendering and associated fixes.
@nautobot-bot @smk4664 @jtdub
Cookie updated by NetworkToCode Cookie Drift Manager Tool (#927)
bf4bf20 
* Cookie updated by NetworkToCode Cookie Drift Manager Tool

Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.5.0",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-app-golden-config.git",
    "path": "/tmp/tmpn7c5gn0b/nautobot-app-golden-config",
    "repository_path": "/tmp/tmpn7c5gn0b/nautobot-app-golden-config",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@itdependsnetworks @jeffkala @nkallergis",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_golden_config",
        "verbose_name": "Golden Config",
        "app_slug": "nautobot-golden-config",
        "project_slug": "nautobot-app-golden-config",
        "repo_url": "https://github.com/nautobot/nautobot-app-golden-config",
        "base_url": "golden-config",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotGoldenConfig",
        "project_short_description": "An app for configuration on nautobot",
        "model_class_name": "ComplianceFeature",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/golden-config/en/latest",
        "_extensions": [
            "local_extensions.camel_case_to_kebab",
            "local_extensions.camel_case_to_words"
        ],
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpn7c5gn0b",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.5.0"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.RUFF",
        "PostAction.POETRY"
    ],
    "baked_commit_ref": "cc1a95931455ed52b0a30b22257e5c8fbdcd212d",
    "draft": false
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.5.0",
    "pull_request": null,
    "post_action": [
        "ruff",
        "poetry"
    ],
    "disable_post_actions": true,
    "draft": false
}
```

* Revert unnecessary changes. Fix docs warnings and lock packages.

* Remove Intended Repository Matching Rule

This section that the documentation is rerfering to was removed in PR 205.

* Revert minimum test version change.

---------

Co-authored-by: bakebot <info@networktocode.com>
Co-authored-by: Stephen Kiely <stephenkiely87@gmail.com>
@jtdub
initial stab at upgrading hier config in golden config
b62fb0a
@jtdub
update docstring and exceptions
06e9fe0
@jtdub
ruff
0016999
@jtdub
pylint
2a52816
@jtdub
remove duplicate line
daec19b
@jtdub
pylint
a2f7004
@jtdub
Merge pull request #902 from nautobot/hierv3
5ddad5c 
Hier Config V3 Upgrade
@jeffkala
get unittest passing and other updates
f9d822b
@icovada @smk4664
Verify no other object has same time before changing it (#952)
683694d 
* Verify no other object has same time before changing it

* fragment

* rename to .fixed

* Update 951.fixed

---------

Co-authored-by: Stephen Kiely <stephenkiely87@gmail.com>
@cmsirbu
Added Analytics template override only to RTD docs build (#969)
cf1ce81 
* Added Analytics template override only to RTD docs build
@joewesch
Adding a fail option to config plan deployment job (#956)
aeb4569 
* Adds fail option to config plan deployment job

* Adds config_deployment unit tests

* Fixes import sorting

* Fixes test
@jeffkala
Fix poetry lock file version (#971)
699ebc7 
* fix lock file from 2.x to 1.8 version
@jeffkala @itdependsnetworks
migrate golden config setting model to ui component framework (#962)
a299fc2 
* migrate golden config setting model to ui component framework

Co-authored-by: Ken Celenza <ken@celenza.org>

* fix tests by removing incorrect retrieve context calls

* Update nautobot_golden_config/details.py

Co-authored-by: Ken Celenza <ken@celenza.org>

---------

Co-authored-by: Ken Celenza <ken@celenza.org>
@joewesch @jeffkala
Adding the ability to sync remediation settings via git (#958)
e6096af 
* Adds remediation settings datasource sync

Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>

---------

Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
@nautobot-bot @itdependsnetworks
Cookie updated by NetworkToCode Cookie Drift Manager Tool (#980)
4630bdf 
* Cookie updated by NetworkToCode Cookie Drift Manager Tool

Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "nautobot-app-v2.5.1",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-app-golden-config.git",
    "path": "/tmp/tmpylov6jsc/nautobot-app-golden-config",
    "repository_path": "/tmp/tmpylov6jsc/nautobot-app-golden-config",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@itdependsnetworks @jeffkala @nkallergis",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_golden_config",
        "verbose_name": "Golden Config",
        "app_slug": "nautobot-golden-config",
        "project_slug": "nautobot-app-golden-config",
        "repo_url": "https://github.com/nautobot/nautobot-app-golden-config",
        "base_url": "golden-config",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotGoldenConfig",
        "project_short_description": "An app for configuration on nautobot",
        "model_class_name": "ComplianceFeature",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/golden-config/en/latest",
        "_extensions": [
            "local_extensions.camel_case_to_kebab",
            "local_extensions.camel_case_to_words"
        ],
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpylov6jsc",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "nautobot-app-v2.5.1"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [],
    "baked_commit_ref": "32eca1dae402d8723ffa835c9c282742813aaf51",
    "draft": false
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "nautobot-app-v2.5.1",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": true,
    "draft": null
}
```
---------

Co-authored-by: bakebot <info@networktocode.com>
Co-authored-by: itdependsnetworks <ken@celenza.org>
@jeffkala
sync in develop
afde01a
@jeffkala
commit before potentially starting over
0282f8e
@jeffkala
Copy link
Copy Markdown
Contributor Author

jeffkala commented Sep 26, 2025

closing as its being covered in: #984

@jeffkala jeffkala closed this Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks will be requested when the pull request is marked ready for review itdependsnetworks is a code owner

@nkallergis nkallergis Awaiting requested review from nkallergis nkallergis will be requested when the pull request is marked ready for review nkallergis is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@jeffkala @gsnider2195 @itdependsnetworks @mattmiller87 @nautobot-bot @joewesch @robertoduarte-codilime @jtdub @icovada @cmsirbu