Add second type of JSON compliance using Jdiff#920
Draft
Add second type of JSON compliance using Jdiff#920
Conversation
mzbroch
reviewed
Aug 11, 2025
jeffkala
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
|
|
||
| TYPE_CLI = "cli" | ||
| TYPE_JSON = "json" | ||
| TYPE_JSON_DEEPDIFF = "json-deepdiff" |
Contributor
There was a problem hiding this comment.
I think for backwards compat, we will need to keep json as an option that maps to deepdiff
| {% if item.rule.config_type == "xml" %} | ||
| <span id="{{ item.rule|slugify }}_actual"><pre><code class="language-xml">{{ item.actual|placeholder }}</code></pre></span> | ||
| {% elif item.rule.config_type == "json" %} | ||
| {% elif "json" in item.rule.config_type %} |
Contributor
There was a problem hiding this comment.
Suggested change
| {% elif "json" in item.rule.config_type %} | |
| {% elif item.rule.config_type in ["json", "json-deepdiff", "json-jdiff"] %} |
Contributor
Author
|
@itdependsnetworks here's an example of nested version you wanted. needless to say, I don't think this is what anybody would want. |
Contributor
Author
|
Converting back to DRAFT , will need to do additional work on JDIFF for the missing and extra to keep the root/parent key structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #
What's Changed
To Do