Remove conditional UI views

[jtdub]

What's Changed

Addresses the requirement of #842 to remove conditional UI views when compliance, intended, or backup settings are enabled / disabled.

These items can be hidden from the UI with saved UI views. However, there are scenarios where displaying that information is necessary, even if the setting is disabled. For example, we have a job that backs up devices through a separate process and updates the backup timestamps in the ORM. Since the built-in golden config setting is disabled, the ability to see the last time backups were run is unavailable by default. This adjustment ensures that view is still accessible.

To Do

• Explanation of Change(s)

[itdependsnetworks]

We just need to test locally, will try to over next two weeks.

[itdependsnetworks]

I do notice there is logic that needs to be removed in tables.py.

[itdependsnetworks]

Remove:

• nautobot-app-golden-config/nautobot_golden_config/views.py

  Lines 102 to 111 in 39d4876

  	def get_extra_context(self, request, instance=None, **kwargs):
  	"""Get extra context data."""
  	context = super().get_extra_context(request, instance)
  	context["compliance"] = constant.ENABLE_COMPLIANCE
  	context["backup"] = constant.ENABLE_BACKUP
  	context["intended"] = constant.ENABLE_INTENDED
  	jobs = []
  	jobs.append(["BackupJob", constant.ENABLE_BACKUP])
  	jobs.append(["IntendedJob", constant.ENABLE_INTENDED])
  	jobs.append(["ComplianceJob", constant.ENABLE_COMPLIANCE])

• jobs.py in general, including

  nautobot-app-golden-config/nautobot_golden_config/jobs.py

  Lines 57 to 64 in 39d4876

  	if constant.ENABLE_BACKUP and job_name == "nautobot_golden_config.jobs.BackupJob":
  	repo_types.extend(["backup_repository"])
  	if constant.ENABLE_INTENDED and job_name == "nautobot_golden_config.jobs.IntendedJob":
  	repo_types.extend(["jinja_repository", "intended_repository"])
  	if constant.ENABLE_COMPLIANCE and job_name == "nautobot_golden_config.jobs.ComplianceJob":
  	repo_types.extend(["intended_repository", "backup_repository"])
  	if "All" in job_name:
  	repo_types.extend(["backup_repository", "jinja_repository", "intended_repository"])

• tables.py in general, including

  nautobot-app-golden-config/nautobot_golden_config/tables.py

  Lines 125 to 130 in 39d4876

  	if ENABLE_BACKUP:
  	active_fields.append("backup_last_success_date")
  	if ENABLE_INTENDED:
  	active_fields.append("intended_last_success_date")
  	if ENABLE_COMPLIANCE:
  	active_fields.append("compliance_last_success_date")

• datasource.py in general including

  nautobot-app-golden-config/nautobot_golden_config/datasources.py

  Line 13 in 39d4876

  from nautobot_golden_config.utilities.constant import ENABLE_BACKUP, ENABLE_COMPLIANCE, ENABLE_INTENDED

• remove from adr:

  nautobot-app-golden-config/docs/dev/arch_decision.md

  Lines 34 to 55 in 39d4876

  	## Dynamic Application Features
  	There are features within the application that can be turned on/off for backup, compliance, and intended. When they are toggled, this will update what is shown in:
  	- Navigation
  	- Jobs
  	- Data Sources
  	- Tables
  	- Template Contents
  	This is generally handled with a pattern similar to:
  	```python
  	jobs = []
  	if ENABLE_BACKUP:
  	jobs.append(BackupJob)
  	if ENABLE_INTENDED:
  	jobs.append(IntendedJob)
  	if ENABLE_COMPLIANCE:
  	jobs.append(ComplianceJob)
  	jobs.extend([AllGoldenConfig, AllDevicesGoldenConfig])
  	```

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
nautobot_golden_config
navigation.py
Project Total

This report was generated by python-coverage-comment-action

[jeffkala]

closing as its being covered in: #984