Conversation
47e4b89 to
3113bf9
Compare
|
|
AS far as this concern: "UI-based configuration settings would apply to each device individually within a dynamic group, rather than checking the configuration globally once." I don't expect this to cause much performance issue as we already have function |
1691aa5 to
452947c
Compare
jeffkala
left a comment
There was a problem hiding this comment.
Also looks like you're missing the EXXX.md files in the mkdocs.yml file to be rendered on the actual docs. site.
|
@jtdub I still feel like the error messages are a bit off. Maybe its related to the actual git-repo side of it. Backup on a device in a GC setting where backups are disabled I get Its because we do some determination on what repos must be synced at the beginning of each job. I'm testing now and will report back any other things I'd like fixed but getting closer!! Seems like the get setting is the problem Really isn't good enough as inscope devices can be apart of different GC settings. This works fine if you really have a single config setting, but breaks when there is multiple. |
|
feel like in general to make all the different conditional checks we do throughout we need
Maybe something like from nautobot_golden_config.utilities.helper import get_golden_config_settings
class CustomFilterSettings:
def __init__(self, queryset):
self.queryset = queryset
def get_unique_inscope_gcs(self, device_qs):
return set(get_device_to_settings_map(device_qs).values())
def get_backup_enabled(self):
return {"true": [device for device in self.queryset if device.backup_enabled],
"false": [device for device in self.queryset if not device.backup_enabled]}
def get_backup_repos(self):
return [GitRepsitory.object.filter(....)]
def get_intended_enabled(self):
return {"true": [device for device in self.queryset if device.intended_enabled],
"false": [device for device in self.queryset if not device.intended_enabled]}
def get_intended_repos(self):
return return [GitRepsitory.object.filter(....)] |
|
closing as its being covered in: #984 |

Closes #842.
Navigation views display all options regardless of what is enabled or disabled:
Golden Config Settings displays whether backups and intended are enabled:
Creating and Updating Golden Config Settings in the UI:
Reading the Golden Config Settings in the UI.