NAPPS-953 | Use nautobot_plugin_nornir default configuration - #1148
Open
jtdub wants to merge 4 commits into
Open
NAPPS-953 | Use nautobot_plugin_nornir default configuration#1148jtdub wants to merge 4 commits into
jtdub wants to merge 4 commits into
Conversation
nautobot-plugin-nornir 3.2.4 supplies nornir_settings as an app default, so this repo no longer needs to restate it. The removed block was byte-identical to that default. Remove the nautobot_plugin_nornir entry from the development config and from the install docs sample, including the empty placeholder entry in the custom_dispatcher example. Raise the dependency floor to >=3.2.4 so the default is guaranteed to be present. No source change is needed. This app imports nautobot_plugin_nornir.constants.NORNIR_SETTINGS, which now returns the merged defaults.
jtdub
changed the title
jtdub
changed the title
jtdub
marked this pull request as ready for review
August 20, 2026 18:52
jtdub
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
August 20, 2026 18:52
itdependsnetworks
approved these changes
Aug 20, 2026
The previous lock was a full re-resolution. It changed 3881 lines and moved nautobot from 3.1.6 to 3.2.3, a minor version bump this change does not need. The lock now changes 38 lines and keeps nautobot at 3.1.6. Record the residual nornir-nautobot and pylint-nautobot moves in the dependencies fragment.
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: NAPPS-953
What's Changed
nautobot-plugin-nornir3.2.4 suppliesnornir_settingsas an app default. The default comes from this repo's block, so the removed block is identical to it. This change has no effect at run time.nautobot_plugin_nornirentry fromdevelopment/nautobot_config.py. The app stays in thePLUGINSlist.docs/admin/install.md."nautobot_plugin_nornir": {}placeholder from thecustom_dispatchersample. The placeholder no longer has a purpose.nautobot-plugin-nornirfrom">=3.0.0,<4.0.0"to">=3.2.4,<4.0.0". The floor is necessary because the configuration now depends on the 3.2.4 default.This app imports
nautobot_plugin_nornir.constants.NORNIR_SETTINGS. Release 3.2.4 merges the defaults inside the app, so that import returns the complete dictionary. No source change is necessary.To Do