Fix the Execute dropdown not carrying selected devices from the GC Overview page - #1140
Open
pastoreerrante wants to merge 1 commit into
Open
Fix the Execute dropdown not carrying selected devices from the GC Overview page#1140pastoreerrante wants to merge 1 commit into
pastoreerrante wants to merge 1 commit into
Conversation
pastoreerrante
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
July 20, 2026 17:04
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Re-submission of #1138, which was reverted by #1139. Reintroduces the fix now that the revert has been merged and hence re-submission is now possible.
Closes: #1136
What's Changed
Each row checkbox now exposes its Device PK via a
data-device-pkattribute (the checkboxvalueattribute stays the GoldenConfig PK, which bulk edit/delete actions rely on).A small JS function in
execute_with_selected.jsgets now loaded on the page and it reads those attributes when one of three links in theExecutedropdown gets clicked. This JS function appends one or more?device=<pk>query parameter to the Job/runURL, pre-filling the job'sdevicefield so the user doesn't need to re-select the devices once more.A couple of tests have been added to assert the
Config Overviewpage has everything needed to allowexecute_with_selected.jsto perform its job.