Added configurable empty_compliance_behavior setting to `GoldenConf… - #1105
Open
itdependsnetworks wants to merge 2 commits into
Open
Added configurable empty_compliance_behavior setting to `GoldenConf…#1105itdependsnetworks wants to merge 2 commits into
empty_compliance_behavior setting to `GoldenConf…#1105itdependsnetworks wants to merge 2 commits into
Conversation
…igSetting` to control how compliance is evaluated when configurations are empty.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
jeffkala
requested changes
Apr 30, 2026
Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
jeffkala
approved these changes
May 27, 2026
jeffkala
left a comment
jeffkala
left a comment
Contributor
There was a problem hiding this comment.
Re-review looking good. I'm excited for this option.
| "compliance_int", | ||
| aggregation=Max, | ||
| ) | ||
| features = self.queryset.values_list("rule__feature__slug", flat=True).distinct() |
Contributor
Author
There was a problem hiding this comment.
Let's document this better.
| division-by-zero. | ||
| """ | ||
| device_filter = Q(feature__rule__device__in=device_ids) | ||
| # Exclude N/A records (compliance is NULL when configs are empty and behavior is non-default) |
Contributor
Author
There was a problem hiding this comment.
Let's add on to this documentation as well.
Contributor
Author
|
Feedback:
|
gsnider2195
approved these changes
Jun 18, 2026
gsnider2195
left a comment
gsnider2195
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me pending feedback added in today's review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…igSetting` to control how compliance is evaluated when configurations are empty.
Fixes: #421 and potentially solution for #518