Generalize to handle different I2C ports, fix some subtle bugs#3
Open
jmford-engr wants to merge 4 commits into
Open
Generalize to handle different I2C ports, fix some subtle bugs#3jmford-engr wants to merge 4 commits into
jmford-engr wants to merge 4 commits into
Conversation
Added CCHM Example program
… dual I2C ports Tested with Teensy 4.1. Added check to see if there is overflow in the calculation for the CAL register. It was silently failing if the number calculated was more than 65536.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I added a parameter to the constructor that allows the library to be used on boards with multiple Wire ports. I tested it on Teensy 4.1.
Also, I added a member function to dump the registers in the INA220 for debugging purposes.
I fixed a bug in the configuration enums for the gain settings.
I also added a check in the initialization to catch the case where the calibration register overflows 16 bits. I had that happen when I changed the MAX_AMPS to 2, and the microOhms to 10000.
Thanks for contributing this. It works great for me.