Open
Conversation
…ing immediate votes for competing forks. Key changes: - Remove vote spacing check from reply() in vote_generator.cpp - Update vote_spacing implementation to track most recent fork votes - Fix tests to reflect new vote spacing behavior
Test Results for Commit 0bc0a2cPull Request 4840: Results Test Case Results
Last updated: 2025-02-16 16:17:14 UTC |
pwojcikdev
reviewed
Feb 5, 2025
Contributor
|
I modified the vote spacing class to track votes by qualified root, which simplified the code and it eliminated the need to handle ambiguity. |
pwojcikdev
force-pushed
the
prs/fix_vote_spacing
branch
from
cfded44 to
0bc0a2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
votable()method had incorrect logic that allowed voting on recentlyvoted blocks when it should have prevented them. Fix inverts the logic to:
Additional changes: