Update libdigidocpp to v4.4.0 and remove build hacks#6
Draft
lnagel wants to merge 5 commits into
Draft
Conversation
Upstream now uses PROJECT_SOURCE_DIR (fixes CMAKE_SOURCE_DIR issue) and includes static targets in the export set (fixes install(EXPORT) failure). Removes the symlink workaround and ANDROID=TRUE hack. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move from master snapshot (v4.3.0-16-ge232b19) to the official v4.4.0 tag for a reproducible release. PR #722 (PDB install guard) and #723 (digidocpp_EXPORTS) landed/are pending after v4.4.0, so both upstream build hacks remain in place. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…regression Previous CI at this exact pin passed on macOS arm64 and Windows on 2026-03-16 (run 23143995035). v4.4.0 currently segfaults on second initialize_lib() call on those platforms. This revert tests whether the regression is in v4.4.0 (only 5 lines changed in TSL.cpp) or due to environmental drift since March. This commit will be reverted depending on CI outcome. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CI diagnostic at submodule pin e232b19 (run 26246671120) showed the same macOS/Windows segfault as v4.4.0, confirming the bug is not in v4.4.0 — it is an environmental issue exposed by EU TSL data drift since the last passing CI on 2026-03-16. libdigidocpp segfaults on init -> terminate -> init cycles on macOS/Windows with current TSL data; Linux is unaffected. Workaround: - Make the `lib` test fixture session-scoped (one init per session). - Skip `test_initialize_lib_custom_path` on non-Linux platforms; it intentionally exercises a second init after terminate, which is what triggers the upstream bug. Submodule re-pinned to v4.4.0 tag (this reverts d2a40f4 diagnostic). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update libdigidocpp submodule from v4.3.0 to v4.4.0 (official release tag, commit
68ec5bf).CMAKE_SOURCE_DIRtoPROJECT_SOURCE_DIR(#716)ANDROID=TRUEhack — upstream now includes static targets in export set (#717)Remaining hacks (pending upstream, not in v4.4.0)
install()override — open-eid/libdigidocpp#722 merged to master on 2026-05-19, after the v4.4.0 tag (2026-04-15). Will be in the next upstream release.digidocpp_EXPORTSdefine — open-eid/libdigidocpp#723 still open.Both hacks stay until a future upstream release; documented in
CLAUDE.md.Test plan
uv build --wheelsucceeds on Linuxuv run pytest tests/ -v— all 22 tests pass