Cross-project review cleanups#4
Merged
Merged
Conversation
The wheel.exclude for lib/** and include/** is unnecessary since upstream install() rules are suppressed — the build never produces those directories. Add Changelog URL pointing to GitHub releases for PyPI metadata. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Match upload-artifact@v7 with download-artifact@v7 for consistency. Move `source gcc-toolset-13/enable` before both OpenSSL and xmlsec1 builds so the GCC 13 compiler is explicitly active for all compilations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add %$not %$isconstructor and %$not %$isdestructor to both %rename directives, matching pycdoc's pattern. Prevents potential issues with constructor naming being converted to snake_case. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace `pip install .` with `uv build --wheel && pip install dist/*.whl` for consistency with CLAUDE.md and the actual dev workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add conftest.py with lib fixture to reduce initialize/terminate boilerplate in integration tests. Add tests for app_info(), user_agent(), and initialize_lib() with custom schema path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The initialize() and initialize_lib() parameter `user_agent` shadowed the imported `user_agent` function from the SWIG module. Rename to `user_agent_str` to avoid confusion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mark 10 items as done with explanations. 4 items remain deferred: OpenSSL upgrade, PR build gating, RELINKING.md pip instructions, director test assertion, and upstream version tracking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace `pip install build && python -m build --wheel` with `uv build --wheel` for consistency with the rest of the project. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use `uv add` for installation, `uv tool install` for CI build tools, and `uv run --with` for ad-hoc test dependencies. No pip references remain in the project. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep as a local working file, not committed to the repository. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Revert CIBW_BEFORE_BUILD from `uv tool install` back to `uv pip install --system` — uv tool install puts binaries in isolated envs where CMake's find_package cannot find them - Revert test step to multi-line uv venv/pip install approach - Restore `pip install pydigidoc` in README (universal for end users) - Restore pip-based build instructions in RELINKING.md (LGPL compliance users may not have uv) - Revert user_agent parameter rename to avoid public API break Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
upload-artifact@v7 does not exist — v6 is the latest. The original v6 was correct; download-artifact@v7 is compatible with upload-artifact v4+. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-project review cleanups. 8 files changed.
pyproject.toml
wheel.exclude— build never produceslib/orinclude/dirs since upstreaminstall()rules are suppressedChangelogURL pointing to GitHub releasesCI (.github/workflows/build.yml)
source gcc-toolset-13/enablebefore all builds so GCC 13 is explicitly active for both OpenSSL and xmlsec1 compilationSWIG interface
%$not %$isconstructor, %$not %$isdestructorto%renamerules, matching pycdoc's pattern to prevent potential constructor naming issuesDocumentation
uv build --wheelTests
libpytest fixture inconftest.pyto replace manualtry/finallyinit/terminate boilerplateapp_info(),user_agent(), andinitialize_lib()with custom schema pathHousekeeping
TODO.mdto.gitignore(local working file)Deferred
Test plan
uv run pytest tests/ -v— 22 tests passinguv build --wheel— wheel builds successfully🤖 Generated with Claude Code