Fix Windows wheel build#2
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CMAKE_SKIP_INSTALL_RULES doesn't prevent generator expression evaluation. Override install() as a conditional no-op instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lnagel
force-pushed
the
fix/windows-build
branch
from
f9a9dff to
07c55ae
Compare
Two issues: 1. Override install() as no-op during add_subdirectory to prevent TARGET_PDB_FILE errors on static/missing targets 2. Define digidocpp_EXPORTS on static lib targets to prevent __declspec(dllimport) errors (C2491) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMAKE_SKIP_INSTALL_RULESto avoid upstream PDB generator expression errorsContext
Upstream
src/CMakeLists.txthas unconditional$<TARGET_PDB_FILE:...>references that fail with static builds on Windows. See open-eid/libdigidocpp#715.🤖 Generated with Claude Code