-
Notifications
You must be signed in to change notification settings - Fork 184
Add FFM version of Pageant AgentConnector #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
norrisjeremy
wants to merge
12
commits into
mwiede:master
Choose a base branch
from
norrisjeremy:20260220
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+559
−14
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4ba9cda
Don't try to close an INVALID_HANDLE_VALUE.
norrisjeremy 7bf6028
Correctly use FILE_MAP flags instead of SECTION_MAP flags when callin…
norrisjeremy a146e81
Better differentiate errors & also include GetLastError() value.
norrisjeremy 3343a7f
Update Pageant shared mapping name to use a combination of GetCurrent…
norrisjeremy 5ff0202
Add FFM version of Pageant AgentConnector.
norrisjeremy 2aca3ad
Throw an exception if the shared file mapping already exists.
norrisjeremy 9e5f5c2
Only check for NULL when checking for failure from CreateFileMapping(…
norrisjeremy e24e3a7
Update Pageant shared mapping name to only use the GetCurrentProcessI…
norrisjeremy b24b64d
Make file mapping owned by the user SID, matching PuTTY's behavior.
norrisjeremy 345f1e0
Normalize Exception messages.
norrisjeremy 7f9070e
Add GetLastError() wrapper method.
norrisjeremy bafc0b2
Use try/finally when cleaning up multiple resources in case one clean…
norrisjeremy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.jcraft.jsch; | ||
|
|
||
| import com.jcraft.jsch.annotations.SuppressForbiddenApi; | ||
|
|
||
| final class JavaThreadId { | ||
|
Check warning on line 5 in src/main/java/com/jcraft/jsch/JavaThreadId.java
|
||
|
|
||
| @SuppressForbiddenApi("jdk-deprecated") | ||
| static long get() { | ||
| return Thread.currentThread().getId(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Copyright (c) 2011 ymnk, JCraft,Inc. All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without modification, are permitted | ||
| * provided that the following conditions are met: | ||
| * | ||
| * 1. Redistributions of source code must retain the above copyright notice, this list of conditions | ||
| * and the following disclaimer. | ||
| * | ||
| * 2. Redistributions in binary form must reproduce the above copyright notice, this list of | ||
| * conditions and the following disclaimer in the documentation and/or other materials provided with | ||
| * the distribution. | ||
| * | ||
| * 3. The names of the authors may not be used to endorse or promote products derived from this | ||
| * software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
| * DISCLAIMED. IN NO EVENT SHALL JCRAFT, INC. OR ANY CONTRIBUTORS TO THIS SOFTWARE BE LIABLE FOR ANY | ||
| * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR | ||
| * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| package com.jcraft.jsch; | ||
|
|
||
| public class PageantFFMConnector implements AgentConnector { | ||
|
|
||
| public PageantFFMConnector() throws AgentProxyException { | ||
| throw new AgentProxyException("PageantFFMConnector requires Java23+."); | ||
| } | ||
|
|
||
| @Override | ||
| public String getName() { | ||
| throw new UnsupportedOperationException("PageantFFMConnector requires Java23+."); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isAvailable() { | ||
| throw new UnsupportedOperationException("PageantFFMConnector requires Java23+."); | ||
| } | ||
|
|
||
| @Override | ||
| public void query(Buffer buffer) throws AgentProxyException { | ||
| throw new UnsupportedOperationException("PageantFFMConnector requires Java23+."); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.jcraft.jsch; | ||
|
|
||
| final class JavaThreadId { | ||
|
Check warning on line 3 in src/main/java19/com/jcraft/jsch/JavaThreadId.java
|
||
|
|
||
| static long get() { | ||
| return Thread.currentThread().threadId(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround for manuelbl/WindowsApiGenerator#7 that I opened.
I also opened manuelbl/WindowsApiGenerator#9 with a possible solution.
Once this issue is resolved upstream, we should be able to remove this
find-and-replace-maven-plugin.