Improve RSP accuracy by backporting changes from simple64#1153
Draft
Rosalie241 wants to merge 3 commits into
Draft
Improve RSP accuracy by backporting changes from simple64#1153Rosalie241 wants to merge 3 commits into
Rosalie241 wants to merge 3 commits into
Conversation
This was referenced Sep 26, 2025
Merged
LibretroAdmin
added a commit
to libretro/parallel-n64
that referenced
this pull request
Jun 9, 2026
Backports the RSP accuracy improvements from libretro/parallel-rsp#17 (by Rosalie241, originally from simple64) into the vendored mupen64plus-rsp-paraLLEl. - rsp_dma_read/rsp_dma_write: rewrite length/count/skip handling (length = ((len & 0xFFF) | 7) + 1, skip masked 0xFF8, count + 1, DMA_CACHE & 0x1ff8, DMA_DRAM & 0xfffff8, loop ++i < count). - SP_STATUS write: per-bit SP_SET_/SP_CLR_ handling. - DPC register logic: rdp_status_write(), CMD_START/CMD_END with DPC_STATUS_START_VALID, semaphore-write-zeros. - Replace the MFC0_count timeout mechanism with the SP_SEMAPHORE path; add a MODE_EXIT run-loop exit (parallel.cpp / rsp_jit.cpp). Passes all 305 n64-systemtest RSP tests (interpreter, LLE video, parallel RSP), per the upstream PR. The local rsp_jit.cpp uint16_t(imm) immediate fix is preserved. NOTE: the upstream PR also wants a companion mupen64plus-core change (mupen64plus/mupen64plus-core#1153). The parallel-n64 core may need a matching adjustment for the new DPC START_VALID / CMD handshake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all RSP tests with the interpreter, a LLE video plugin & parallel RSP:
n64-systemtest-rsp.zip
This also requires a parallel-rsp patch: libretro/parallel-rsp#17