Correct block ids#138
Open
Manalelaidouni wants to merge 1 commit intomultimodal-art-projection:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey great project! I want point out that using
BlockTokenRangeProcessor(32016, 32016)blocks an empty range because it's exclusive at the end, that means the xcodec id 32016 is not being blocked from generation, so range should be (32016, 32017) to block 32016, same update for otherBlockTokenRangeProcessorranges in infer.py, I rerun the inference code while disabling sampling in generation to keep it determinestic and the output is the same after the edit,