Fix output grid and sql console#1621
Closed
dnlw07 wants to merge 8 commits into
Closed
Conversation
Fix operator precedence bug in _openResultsWebview and missing loading state on reused result panels. The change cause that: - Result tabs are now correctly reused according to sqltools.results.reuseTabs settings instead of spawning duplicate tabs. - Reused result panels now show a loading spinner while a query is running, matching the behavior of freshly opened panels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Console messages panel
MessagesProvider.MAX_ITEMS), prepended newest-first (explorer/index.ts).getAllConsoleMessages/clearConsoleMessages.REQUEST_SYNC_CONSOLE_MESSAGESround-trip and the "Not focused to results view" message entirely (results.ts, ResultsContext.tsx).Results grid (Table)
Escclears selection,Ctrl/Cmd+Aselects all rows (ignored while focus is in an input/textarea).Shift+clickselects a range from the anchor,Ctrl/Cmd+clicktoggles individual rows.Connection management
sqltools.connectionSwitchsetting: auto-switches the active connection based on glob patterns matched against the focused file's name/path (globMatchin extension.ts).statusBar.setText()call, fixing it not updating when the SQLTools tree view isn't visible.package.json
copyAllConsoleMessages,clearConsoleMessages, and the newsqltools.connectionSwitchconfiguration schema.