Ensure update and close buttons always appear on edit configuration card#203
Open
eepyaich wants to merge 4 commits into
Open
Ensure update and close buttons always appear on edit configuration card#203eepyaich wants to merge 4 commits into
eepyaich wants to merge 4 commits into
Conversation
eepyaich
requested review from
BryanSoltis,
jamasten and
jocontr
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Edit Configuration modal layout so the footer action buttons (Update/Close) are consistently visible by placing the footer within the modal content container.
Changes:
- Repositions the modal footer relative to
modern-modal-contentto address button visibility at certain zoom levels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my browser, the Update and Close buttons on the footer of the edit configuration card were not appearing unless I reduced my browser zoom levels.
The fix, I believe, is to move the footer into the modern-modal-content, rather than have it outside the content.