Examples: Remove "setDecoderPath" in non-gltf path examples#33604
Merged
Conversation
Mugen87
approved these changes
May 19, 2026
# Conflicts: # examples/misc_exporter_usdz.html # examples/webgl_loader_draco.html # examples/webgl_postprocessing_gtao.html # examples/webgl_postprocessing_ssr.html # examples/webgpu_caustics.html # examples/webgpu_postprocessing_ao.html # examples/webgpu_postprocessing_ssr.html # examples/webgpu_upscaling_fsr1.html # examples/webgpu_upscaling_taau.html # examples/webgpu_volume_caustics.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #33564 (comment)
Description
Removes calls to "setDecoderPath" in cases where the examples are setting it to the full "jsm/libs/draco/" decoder (now the default load URL).
There are still examples that load from "jsm/libs/draco/gltf", which I'm also willing to remove so our examples demonstrate use that works globally across bundlers as well as vanilla JS, but the gltf draco bundles are a bit smaller than the versions: