Apply #6 to yaml for G1 with hands#8
Merged
Conversation
Contributor
Author
|
I and/or @Michi-Tsubaki will check if this PR works without strange behaviors. |
Owner
|
Thank you. I'm waiting for the feedback. |
Contributor
Owner
|
Thank you for checkin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At #6, ros2_control yaml for G1 with hands was not used, so that file was not changed.
After #5 was merged, that file has been used, so we have to apply the same change as #6 to that file.
In addition, the same change applied to a hand controller has a different effect.
It prevents the jittery motion caused by #7 because #7 sometimes (not always) also breaks the first point of the interpolation.