Skip to content
This repository was archived by the owner on Jul 3, 2019. It is now read-only.

Fix windows build#2434

Open
ExE-Boss wants to merge 1 commit into
mozilla:masterfrom
EB-Forks:fix/windows-build
Open

Fix windows build#2434
ExE-Boss wants to merge 1 commit into
mozilla:masterfrom
EB-Forks:fix/windows-build

Conversation

@ExE-Boss

@ExE-Boss ExE-Boss commented Apr 6, 2017

Copy link
Copy Markdown

Fixes the \r symbol remaining at the end of entry in the file utils/update-flash-refs.js:194, which resulted in the build not working on Windows.

  Fixes the \r symbol remaining at the end of `entry` in the file
`utils/update-flash-refs.js:194`, which resulted in the build not
working on Windows.

Signed-off-by: ExE Boss <ExE-Boss@users.noreply.github.com>
@ivanpopelyshev

ivanpopelyshev commented Dec 29, 2017

Copy link
Copy Markdown

That's not the only problem in windows build, see https://github.com/mozilla/shumway/pull/2442/files
The best way is just to specify list of files with strict LF

@ExE-Boss

Copy link
Copy Markdown
Author

That \r is put there by the Windows filesystem regardless of the value of eol in .gitconfig, so this patch is still also necessary (this only fixes the extension build).

@ivanpopelyshev

Copy link
Copy Markdown

The idea is that you cant fix the code for xargs in the mozilla-build, so I have to add certain file in ".gitattributes" and prevent git-for-windows auto-CLRF mechanism.

There are many ways to fix that, I made a comment only to get your interest in the project again. Why did you try to build it?

@ExE-Boss

ExE-Boss commented Apr 11, 2018

Copy link
Copy Markdown
Author

I tried to build it because I’m working on #2435.

Also, the purpose of this PR is just to make it possible for grunt firefox or any other grunt build command to complete successfully on Windows without needing to use WSL.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants