This repository was archived by the owner on Jul 3, 2019. It is now read-only.
WIP: Implement BitmapData#getColorBoundsRect#2213
Open
tschneidereit wants to merge 1 commit into
Open
Conversation
And required fixes to BitmapData. Very WIP, much broken.
Contributor
Author
|
/cc @mbebenita |
Contributor
Author
|
Oh and also, |
|
@tschneidereit can you please resolve the mergin conflicts if this is still something we want to land. I can do the review then. If not, please close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And required fixes to BitmapData. Very WIP, much broken.
There is so much inconsistency in BitmapData, particularly around handling of color formats. I think we need to clean all that up, and sooner rather than later, to be able to say, with a straight face, that we support any methods on BitmapData at all.
In particular, various methods just assume the data to be in pARGB format, while others think it's uRGBA. With some uncertainty about byte order sprinkled in. The comment on
_ensureBitmapDatatells a story about converting things to uRGBA, but the implementation converts to pARGB.Fun.