Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
adhusson
approved these changes
Dec 1, 2025
QGarchery
approved these changes
Dec 1, 2025
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
MathisGD
commented
Dec 2, 2025
MathisGD
commented
Dec 2, 2025
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Contributor
Author
|
@codex review again please |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
MathisGD
commented
Dec 2, 2025
MathisGD
commented
Dec 2, 2025
MathisGD
commented
Dec 2, 2025
Contributor
Author
|
@codex review |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
replaced by #845 |
Closed
MathisGD
commented
Dec 3, 2025
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
peyha
approved these changes
Dec 3, 2025
Contributor
peyha
left a comment
peyha
left a comment
There was a problem hiding this comment.
LGTM, we could also add one more dev comment to say that the timelock system is the same as in VaultV2 but not mandatory imo
Contributor
Author
|
done |
QGarchery
approved these changes
Dec 3, 2025
adhusson
reviewed
Dec 3, 2025
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Co-authored-by: Adrien Husson <adhusson@gmail.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.