use docker for linux x86 build#1625
Conversation
|
Review changes with Changed Files
|
myfreess
force-pushed
the
use-docker-for-linux-x86-build
branch
from
563b520 to
ed88056
Compare
| workflow_call: | ||
| outputs: | ||
| image_ref: | ||
| description: Published GHCR image reference with digest | ||
| value: ${{ jobs.publish-ubuntu-image.outputs.image_ref }} |
|
|
||
| publish-ubuntu-image: | ||
| uses: ./.github/workflows/publish-ubuntu-image.yml | ||
| secrets: inherit |
myfreess
force-pushed
the
use-docker-for-linux-x86-build
branch
from
ed88056 to
b86f193
Compare
|
@codex Review. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c13f3954f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| publish-ubuntu-image: | ||
| uses: ./.github/workflows/publish-ubuntu-image.yml | ||
| secrets: inherit |
There was a problem hiding this comment.
This reusable-workflow call does not declare permissions, so it forwards only the repository default GITHUB_TOKEN scopes to the called workflow. GitHub documents that called workflows cannot elevate permissions from the caller (https://docs.github.com/en/actions/using-workflows/reusing-workflows), so when defaults are read-only, publish-ubuntu-image.yml cannot actually get packages: write and GHCR push fails in the image publish step. Set explicit caller-job permissions (at least packages: write and contents: read) here so the release flow does not depend on repo-level defaults.
Useful? React with 👍 / 👎.
2 participants
No description provided.