refactor!: remove moonlex and moonyacc from build system#1575
refactor!: remove moonlex and moonyacc from build system#1575peter-jerry-ye wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b23304799
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else if filename.ends_with(DOT_MBTP) { | ||
| Some(PackageSourceFileKind::Mbtp) | ||
| } else if filename.ends_with(DOT_MBL) { | ||
| Some(PackageSourceFileKind::Mbl) | ||
| } else if filename.ends_with(DOT_MBY) { | ||
| Some(PackageSourceFileKind::Mby) | ||
| } else { | ||
| None |
There was a problem hiding this comment.
Keep legacy extensions watch-relevant in watch mode
Returning None for .mbl/.mby here makes is_watch_relevant_project_file ignore those files, while discovery now hard-fails with UnsupportedLegacyGeneratedSource when they exist. In moon --watch, adding a legacy file after a successful run will not trigger a rerun, so the watch session can keep showing stale success until another relevant file changes. That hides a real build-breaking state and undermines the intended immediate deprecation signal.
Useful? React with 👍 / 👎.
Summary
moonlexandmoonyaccbinary wiring and special RR prebuild nodes.mbl/.mbyas package source kindspre-buildValidation