Fix imported Override attribute handling#225
Open
cameron1729 wants to merge 1 commit intomoodlehq:mainfrom
Open
Fix imported Override attribute handling#225cameron1729 wants to merge 1 commit intomoodlehq:mainfrom
cameron1729 wants to merge 1 commit intomoodlehq:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
============================================
- Coverage 98.27% 98.27% -0.01%
+ Complexity 994 991 -3
============================================
Files 42 42
Lines 2961 2952 -9
============================================
- Hits 2910 2901 -9
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I love that this patch converts multiple instances of code duplication to use the utility helper method that is designed for the task. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods marked with
#[Override]were still triggering some sniffs when the attribute was imported with useOverride;because the checks were looking for exactly\Overrideand missed imported usages like#[Override].This patch updates the sniff to use the qualified attribute name instead of the raw token.