Skip to content

Fix imported Override attribute handling#225

Open
cameron1729 wants to merge 1 commit intomoodlehq:mainfrom
cameron1729:fix-imported-override-attribute
Open

Fix imported Override attribute handling#225
cameron1729 wants to merge 1 commit intomoodlehq:mainfrom
cameron1729:fix-imported-override-attribute

Conversation

@cameron1729
Copy link
Copy Markdown
Contributor

@cameron1729 cameron1729 commented Mar 12, 2026

Methods marked with #[Override] were still triggering some sniffs when the attribute was imported with use Override; because the checks were looking for exactly \Override and missed imported usages like #[Override].

This patch updates the sniff to use the qualified attribute name instead of the raw token.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (5927fc7) to head (ba7ee78).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #225      +/-   ##
============================================
- Coverage     98.27%   98.27%   -0.01%     
+ Complexity      994      991       -3     
============================================
  Files            42       42              
  Lines          2961     2952       -9     
============================================
- Hits           2910     2901       -9     
  Misses           51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jrchamp
Copy link
Copy Markdown
Contributor

jrchamp commented Mar 12, 2026

I love that this patch converts multiple instances of code duplication to use the utility helper method that is designed for the task. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants