Line length ignore for docs#128
Draft
andrewnicols wants to merge 2 commits intomoodlehq:mainfrom
Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
============================================
+ Coverage 97.81% 97.86% +0.04%
- Complexity 827 832 +5
============================================
Files 35 35
Lines 2426 2430 +4
============================================
+ Hits 2373 2378 +5
+ Misses 53 52 -1 ☔ View full report in Codecov by Sentry. |
andrewnicols
force-pushed
the
lineLengthIgnoreForDocs
branch
from
e560258 to
bb27cfc
Compare
Note: This does not apply to inline docs. We should _perhaps_ limit this to things like Behat @Given/When/Then but there are other times when this is not helpful too.
andrewnicols
force-pushed
the
lineLengthIgnoreForDocs
branch
from
bb27cfc to
7aef373
Compare
Member
|
Heh, from the examples in the PR, I feel that only the Maybe we can restrict the skipping to be a little more selecive (by tag, or by regex, ...). Ciao :-) |
Contributor
Author
|
We can... I'll update the patch some time later. Let's not block on this one. It's just one that does my head in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scratching an itch.