Handle invalid poll descriptors in device loop#88
Open
JeffreyBenjaminBrown wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the PR! It seems to address multiple concerns though and, since I cannot reproduce the problem locally (on a couple of distros with both FTDI and CDC grids), I wonder which specific descriptor flag check (or lack of) on which descriptor is causing the problem in the first place? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a possible CPU spin when poll reports POLLNVAL after a device or IPC fd becomes invalid. This may address #81. (Together with a parallel PR I am submitting now to libmonome, it reduced CPU usage from around 45% to negligible on my system, which can be inspected here: https://github.com/JeffreyBenjaminBrown/nixos-experiments/tree/xfce/config.)