Skip to content

fix(utils): preserve newlines in sanitizeString (@bijanmurmu) #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bijanmurmu wants to merge 3 commits into
base: master
Choose a base branch
from
+73 −62
Open

fix(utils): preserve newlines in sanitizeString (@bijanmurmu) #8034

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
331910c
fix(utils): preserve newlines in sanitizeString (@bijanmurmu)
bijanmurmu May 30, 2026
fe0904b
Merge branch 'monkeytypegame:master' into fix-sanitize-string
bijanmurmu May 30, 2026
9b8aeb9
refactor: extract sanitizeString into @monkeytype/util/strings
bijanmurmu May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/utils/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export function sanitizeString(str: string | undefined): string | undefined {
.replace(/[\u0300-\u036F]/g, "")
.trim()
.replace(/\n{3,}/g, "\n\n")
.replace(/\s{3,}/g, " ");
.replace(/[^\S\r\n]{3,}/g, " ");
Copy link
Copy Markdown
Author

@bijanmurmu bijanmurmu May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the regex fix here to ensure newlines aren't accidentally deleted by the backend when users save the profile.

}

const suffixes = ["th", "st", "nd", "rd"];
Expand Down
2 changes: 1 addition & 1 deletion packages/schemas/src/validation/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ function sanitizeString(str: string | undefined): string | undefined {
.replace(/[\u0300-\u036F]/g, "")
.trim()
.replace(/\n{3,}/g, "\n\n")
.replace(/\s{3,}/g, " ");
.replace(/[^\S\r\n]{3,}/g, " ");
Comment thread
bijanmurmu marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Author

@bijanmurmu bijanmurmu May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the exact same fix here as well. Since the function is currently duplicated in the schemas package, I wanted to make sure the bug was completely squashed everywhere it's used.

}

function containsDisallowedWords(
Expand Down
Loading