Trusted publishing#6
Closed
aclark4life wants to merge 5 commits intomongodb-labs:mainfrom
aclark4life:trusted-publishing
Closed
Trusted publishing#6aclark4life wants to merge 5 commits intomongodb-labs:mainfrom aclark4life:trusted-publishing
aclark4life wants to merge 5 commits intomongodb-labs:mainfrom
aclark4life:trusted-publishing
Conversation
There was a problem hiding this comment.
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- justfile: Language not supported
Comments suppressed due to low confidence (3)
django_mongodb_extensions/templates/debug_toolbar/panels/mql.html:127
- The message changed from 'MQL queries' to 'SQL queries'. If this change was not intended, please update the message to reflect the correct terminology.
<p>{% translate "No SQL queries were recorded during this request." %}</p>
django_mongodb_extensions/debug_toolbar/panels/mql/panel.py:60
- The removal of 'databases' from the stats may affect the debug display if this data is still required. Verify that downstream code no longer depends on this field.
"databases": sorted(self._databases.items()),
django_mongodb_extensions/debug_toolbar/panels/mql/panel.py:61
- Removing 'sql_time' could break functionality if it is referenced elsewhere. Confirm that this metric is no longer needed or has been replaced appropriately.
"sql_time": self._sql_time,
| "alias": self.db.alias, | ||
| "sql": operation, | ||
| "time": "%.3f" % duration, | ||
| "duration": "%.3f" % duration, |
There was a problem hiding this comment.
The key for query execution time has been changed from 'time' to 'duration'. Ensure that all code consuming this key is updated accordingly.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+21
to
+47
| build_dist: | ||
| name: Build Distribution Files | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| # Build sdist on lowest supported Python | ||
| python-version: '3.9' | ||
|
|
||
| - name: Install build | ||
| run: | | ||
| python -m pip install build | ||
|
|
||
| - name: build the dist files | ||
| run: | | ||
| python -m build . | ||
|
|
||
| - name: Upload the dist files | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: dist-${{ github.run_id }} | ||
| path: ./dist/*.* |
Check warning
Code scanning / zizmor
default permissions used due to no permissions: block Warning
Comment on lines
+49
to
+82
| test_dist: | ||
| needs: [build_dist] | ||
| name: Test Distribution Files | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| # Build sdist on lowest supported Python | ||
| python-version: '3.9' | ||
|
|
||
| - name: Download the dists | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: dist-${{ github.run_id }} | ||
| path: dist/ | ||
|
|
||
| - name: Test the sdist | ||
| run: | | ||
| cd dist | ||
| pip install *.tar.gz | ||
| python -c "import flask_pymongo" | ||
| pip uninstall -y flask_pymongo | ||
|
|
||
| - name: Test the wheel | ||
| run: | | ||
| cd dist | ||
| pip install *.whl | ||
| python -c "import flask_pymongo" | ||
| pip uninstall -y flask_pymongo |
Check warning
Code scanning / zizmor
default permissions used due to no permissions: block Warning
Comment on lines
+22
to
+38
| static: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
| fetch-depth: 0 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| enable-cache: true | ||
| python-version: ${{ matrix.python-version }} | ||
| - uses: extractions/setup-just@v3 | ||
| - run: just install | ||
| - run: just lint | ||
| - run: just docs | ||
| - run: just doctest |
Check warning
Code scanning / zizmor
default permissions used due to no permissions: block Warning test
Comment on lines
+39
to
+79
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: ["ubuntu-latest", "macos-latest", "windows-latest"] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] | ||
| fail-fast: false | ||
| name: CPython ${{ matrix.python-version }}-${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
| fetch-depth: 0 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| enable-cache: true | ||
| python-version: ${{ matrix.python-version }} | ||
| - uses: extractions/setup-just@v3 | ||
| - name: Start MongoDB on Linux | ||
| if: ${{ startsWith(runner.os, 'Linux') }} | ||
| uses: supercharge/mongodb-github-action@1.12.0 | ||
| with: | ||
| mongodb-version: ${{ env.MAX_MONGODB }} | ||
| mongodb-replica-set: test-rs | ||
| - name: Start MongoDB on MacOS | ||
| if: ${{ startsWith(runner.os, 'macOS') }} | ||
| run: | | ||
| brew tap mongodb/brew | ||
| brew install mongodb/brew/mongodb-community@${MAX_MONGODB} | ||
| brew services start mongodb-community@${MAX_MONGODB} | ||
| - name: Start MongoDB on Windows | ||
| if: ${{ startsWith(runner.os, 'Windows') }} | ||
| shell: powershell | ||
| run: | | ||
| mkdir data | ||
| mongod --remove | ||
| mongod --install --dbpath=$(pwd)/data --logpath=$PWD/mongo.log | ||
| net start MongoDB | ||
| - run: just install | ||
| - run: just test |
Check warning
Code scanning / zizmor
default permissions used due to no permissions: block Warning test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.