chore: upgrade dev dependencies to React 18.2#3410
Open
talkor wants to merge 5 commits into
Open
Conversation
Upgrade devDependencies across all packages to React 18.2 while keeping peerDependencies at >=16.9.0 for consumer compatibility. No source code changes — library remains compatible with React 16/17/18. - Bump react/react-dom devDeps from ^16.x to ^18.2.0 (16 packages) - Upgrade @testing-library/react from ^12 to ^14 - Remove deprecated @testing-library/react-hooks (merged into @testing-library/react) - Remove @hot-loader/react-dom (unused with Vite tooling) - Bump react-is to ^18.2.0 - Fix act() wrapping in tests for React 18 automatic batching - Update snapshots for React 18 output
Contributor
|
📦 Bundle Size Analysis Changed Components
Unchanged Components
📊 Summary:
|
- react-is is a runtime dependency bundled into output — keep at v16 to avoid +3.5KB per component (symbols are stable across React versions) - Wrap interaction test DOM assertions in waitFor() for React 18 batching
Import expect and waitFor from @storybook/test (unified module) instead of separate @storybook/jest import.
Contributor
Code Review by Qodo
1. Invalid renderHook ReturnType typing
|
…test The hook checks document.activeElement against focusedElementRef.current (the inner input). The test was focusing the Search wrapper div found by test-id, which doesn't match — causing the hook to early-return without updating visual focus.
Contributor
PR Summary by Qodochore: upgrade dev React to 18.2 + Testing Library v14; fix React 18 test timing Description
Diagram
High-Level Assessment
Files changed (57)
|
userEvent.keyboard() dispatches events based on user-event's internal focus tracking, not document.activeElement. Calling element.focus() directly doesn't update that tracking, so keyboard events were dispatched on the wrong element. Using userEvent.tab() properly updates both browser focus and user-event's tracked focus target.
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
| const initialStateValue = ""; | ||
| let onChangeCallbackStub: Mock; | ||
| let hookResult: RenderHookResult<unknown, UseDebounceResult>; | ||
| let hookResult: ReturnType<typeof renderHook<UseDebounceResult>>; |
Contributor
There was a problem hiding this comment.
1. Invalid renderhook returntype typing 📘 Rule violation ≡ Correctness
useDebounceEvent.test.ts declares hookResult as `ReturnType<typeof renderHook<UseDebounceResult>>, but applying generic type arguments inside a typeof` type query is invalid TypeScript and can fail the test build/typecheck. This risks breaking CI and undermines the reliability of the migrated React 18 test suite.
Agent Prompt
## Issue description
`packages/core/src/hooks/__tests__/useDebounceEvent.test.ts` types `hookResult` as `ReturnType<typeof renderHook<UseDebounceResult>>`, but generic parameters cannot be applied inside a `typeof` type query, making this invalid TypeScript syntax. This can break TypeScript compilation of the test suite and block CI.
## Issue Context
This PR migrates hook tests from `@testing-library/react-hooks` to `@testing-library/react`, and the intent is to correctly type the value returned by `renderHook(...)` while keeping the tests reliable under the React 18 tooling upgrade.
## Fix Focus Areas
- packages/core/src/hooks/__tests__/useDebounceEvent.test.ts[10-10]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Contributor
|
Code review by qodo was updated up to the latest commit c9caf40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devDependenciesacross all 16 packages to React 18.2 while keepingpeerDependenciesat>=16.9.0— consumers on React 16/17/18 continue to work@testing-library/reactfrom v12 to v14, remove deprecated@testing-library/react-hooks@hot-loader/react-domdependencyact()wrapping in tests for React 18's stricter automatic batchingMotivation
Modernize dev tooling (Storybook, test runner) to React 18 for better DX while preserving backward compatibility for consumers still on React 16/17.
Test plan
🤖 Generated with Claude Code