fix(sdk): handle node builtins in ESM remote loader#4816
Merged
ScriptedAlchemy merged 11 commits intoJul 3, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: ff457b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Thanks for opening the draft PR. This looks like it may address the issue. Since it is still in draft, we'll wait until you mark it as ready for review, then take a closer look. |
Contributor
Author
|
@2heal1 Thank you for your response. I’ve marked the PR as ready for review. Please take a look when you have a chance. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fc8b29b22
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2heal1
approved these changes
Jun 23, 2026
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/playground
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Contributor
Bundle Size Report16 package(s) changed, 26 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 35.70 MB (+53.7 kB (+0.1%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
ScriptedAlchemy
force-pushed
the
fix/node-esm-builtin-loader
branch
from
b77925d to
b14d02a
Compare
ScriptedAlchemy
force-pushed
the
fix/node-esm-builtin-loader
branch
from
84cb48f to
a370d5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle Node.js built-in module imports in the SDK Node ESM remote loader.
This PR updates the
vm.SourceTextModuleloading path used byloadScriptNode(..., { type: 'module' })so that:node:url,node:module, and bare builtins such aspathare loaded with native Node import and returned to the linker asvm.SyntheticModuleinstances.http:andhttps:module URLs; unsupported non-http specifiers fail with a clear error instead of being routed throughfetch.import.meta.url, which allows patterns such ascreateRequire(import.meta.url).The main issue this PR is meant to address is the
node:*builtin path. Theimport.meta.urland dynamic import pieces are adjacent ESM loader fixes found while covering the same Node ESM remote loader flow. I opened this as a draft so maintainers can confirm whether they prefer keeping those together or splitting them.Related Issue
fixes #4815
Types of changes
Checklist
Test Plan
NODE_OPTIONS=--experimental-vm-modules corepack pnpm --filter @module-federation/sdk testcorepack pnpm --filter @module-federation/sdk run lintcorepack pnpm --filter @module-federation/sdk run buildNote:
buildcompletes successfully, with an existing rolldown warning about the pre-existingeval('require')CJS path inpackages/sdk/src/node.ts.