refactor: single-source connection->scope mapping#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Single-sources the connection→scope mapping in
build_di_container: instead of hardcodingScope.REQUEST/Scope.SESSION, it derives each child container's scope from the providers (fastapi_request_provider.scope/fastapi_websocket_provider.scope). TheRequest↔REQUEST/WebSocket↔SESSIONpairing now lives in exactly one place — theContextProviderdefinitions.The
scope: Scope | None = Noneannotation becomes a plainscope = None(inferredIntEnum | None), sinceAbstractProvider.scopeis staticallyIntEnum.Why
The scope a connection's child container is built at must match the scope its
ContextProviderreads from, but the pairing was written twice with nothing enforcing agreement — a latent drift hazard. Deriving the scope from the provider makes them agree by construction.This mirrors the same change just shipped in
modern-di-litestar(#22) — the two integrations carry the identical pattern. (modern-di-faststreamalready eliminated the analogous writer/reader drift by naming its shared container keys.)Behavior
Unchanged. The
if Request / elif WebSocketstructure and thescope=Nonedefault for any other connection are preserved exactly — only the scope source changes. TheContextProviderdefinitions are untouched.Checks
just lint-ci— clean (ruff,ty)just test-ci— 7 passed, 100% line coverageNet 0 lines (3 insertions, 3 deletions).