-
Notifications
You must be signed in to change notification settings - Fork 502
Feat/memory update #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alcholiclg
wants to merge
2
commits into
modelscope:main
Choose a base branch
from
alcholiclg:feat/memory_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/memory update #912
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,6 +120,7 @@ venv.bak/ | |
|
|
||
| .vscode | ||
| .idea | ||
| .cursor | ||
|
|
||
| # custom | ||
| *.pkl | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| """Unified Memory — a protocol-driven, backend-pluggable memory system. | ||
|
|
||
| Register ``unified_memory`` in ``memory_mapping`` to use this system. | ||
|
|
||
| Architecture:: | ||
|
|
||
| Orchestrator --delegates-to--> MemoryBackend (Protocol) | ||
| | | ||
| +----------------+----------------+ | ||
| v v v | ||
| FileBasedBackend ReMeBackend MempalaceBackend ... | ||
| (built-in) (adapter) (adapter) | ||
|
|
||
| Switch backends via YAML config:: | ||
|
|
||
| storage: | ||
| backend: "file" # or "reme", "mempalace", "mem0", "byterover", "supermemory" | ||
| """ | ||
| from .config import MemoryConfig | ||
| from .orchestrator import MemoryOrchestrator | ||
| from .protocols import ( | ||
| BaseMemoryBackend, | ||
| MemoryBackend, | ||
| MemoryEntry, | ||
| MemoryEvent, | ||
| MemoryEventBus, | ||
| MemoryNamespace, | ||
| ) | ||
| from .registry import backend_registry | ||
|
|
||
| # Import backends so they self-register | ||
| from .backends import file_based as _fb # noqa: F401 | ||
|
|
||
| __all__ = [ | ||
| "MemoryConfig", | ||
| "MemoryOrchestrator", | ||
| # Layer 2 — primary contract | ||
| "MemoryBackend", | ||
| "BaseMemoryBackend", | ||
| "backend_registry", | ||
| # Layer 1 — data structures | ||
| "MemoryEntry", | ||
| "MemoryEvent", | ||
| "MemoryEventBus", | ||
| "MemoryNamespace", | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When restoring messages from the session log, the
tool_call_idandnamefields are omitted. This will break the conversation history for tool-use interactions, as many LLM providers require these fields to correctly associate tool outputs with their corresponding calls. These fields should be included in the restoration logic, similar to how they are handled in_dicts_to_messagesin theContextAssembler.