Skip to content

Display opening name - #295

Merged
LuisW04 merged 12 commits into
masterfrom
display-opening-name
Dec 17, 2025
Merged

Display opening name#295
LuisW04 merged 12 commits into
masterfrom
display-opening-name

Conversation

@henrileonard

Copy link
Copy Markdown
Collaborator

Purpose

Describe the feature or solved problems

Pre-merge TODOs and Checks

  • PGN file loads correctly
  • Navigating through the move history works
  • Starting the engine shows moves (test for both sides)
  • Selecting a different variant loads a new board with the variant and you can make moves on the board
  • In Crazyhouse the pocket pieces are shown and you can drop pieces

@LuisW04 LuisW04 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty readable code that makes sense.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backtracking code is very intuitive.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intuitive method names. The comment could be translated to english.

@LuisW04
LuisW04 merged commit bfc2cd9 into master Dec 17, 2025
1 check passed
@henrileonard
henrileonard deleted the display-opening-name branch December 21, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants