[Feat] Codex plugin#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds marketplace and plugin configuration files for AI coding agents and updates the README with installation instructions for Claude Code, Codex, and Gemini CLI. The review feedback identifies several path-related issues: the Codex plugin configuration needs a relative path correction to find the skills directory, and the README instructions for Gemini CLI and manual installations should point directly to the specific skill subdirectory to avoid configuration errors.
| "energy", | ||
| "inference" | ||
| ], | ||
| "skills": "./skills/", |
There was a problem hiding this comment.
The path to the skills directory is likely incorrect. Since this manifest is located within the .codex-plugin/ subdirectory, the relative path to the skills/ directory at the repository root should be ../skills/. Using ./skills/ would cause the tool to look for a skills/ folder inside .codex-plugin/, which does not exist.
| "skills": "./skills/", | |
| "skills": "../skills/", |
|
|
||
| In the plugin browser, select the `ml-energy-data` marketplace and install `skill`. | ||
|
|
||
| Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills`. |
There was a problem hiding this comment.
The path provided for the Gemini CLI installation is likely too broad. The actual skill definition is located in skills/mlenergy-data/. Providing only --path skills might fail if the tool expects the direct path to the directory containing the SKILL.md file. It is safer to point directly to the specific skill folder.
| Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills`. | |
| Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills/mlenergy-data`. |
|
|
||
| Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills`. | ||
|
|
||
| For other tools, you can download the `skills/` directory and place it in the appropriate skills directory. |
There was a problem hiding this comment.
The instruction to download the skills/ directory is ambiguous. If a user places the entire skills/ directory into their tool's skills folder, it will create a nested structure (e.g., ~/.cursor/skills/skills/mlenergy-data/), which most tools will not recognize. It is better to specify that the mlenergy-data subdirectory should be used.
| For other tools, you can download the `skills/` directory and place it in the appropriate skills directory. | |
| For other tools, you can download the `skills/mlenergy-data` directory and place it in the appropriate skills directory. |
No description provided.