Skip to content

[Feat] Codex plugin#4

Closed
jaywonchung wants to merge 2 commits into
masterfrom
jw-codex-plugin
Closed

[Feat] Codex plugin#4
jaywonchung wants to merge 2 commits into
masterfrom
jw-codex-plugin

Conversation

@jaywonchung
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds marketplace and plugin configuration files for AI coding agents and updates the README with installation instructions for Claude Code, Codex, and Gemini CLI. The review feedback identifies several path-related issues: the Codex plugin configuration needs a relative path correction to find the skills directory, and the README instructions for Gemini CLI and manual installations should point directly to the specific skill subdirectory to avoid configuration errors.

Comment thread .codex-plugin/plugin.json
"energy",
"inference"
],
"skills": "./skills/",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The path to the skills directory is likely incorrect. Since this manifest is located within the .codex-plugin/ subdirectory, the relative path to the skills/ directory at the repository root should be ../skills/. Using ./skills/ would cause the tool to look for a skills/ folder inside .codex-plugin/, which does not exist.

Suggested change
"skills": "./skills/",
"skills": "../skills/",

Comment thread README.md

In the plugin browser, select the `ml-energy-data` marketplace and install `skill`.

Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The path provided for the Gemini CLI installation is likely too broad. The actual skill definition is located in skills/mlenergy-data/. Providing only --path skills might fail if the tool expects the direct path to the directory containing the SKILL.md file. It is safer to point directly to the specific skill folder.

Suggested change
Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills`.
Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills/mlenergy-data`.

Comment thread README.md

Gemini CLI also supports `gemini skills install https://github.com/ml-energy/data --path skills`.

For other tools, you can download the `skills/` directory and place it in the appropriate skills directory.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The instruction to download the skills/ directory is ambiguous. If a user places the entire skills/ directory into their tool's skills folder, it will create a nested structure (e.g., ~/.cursor/skills/skills/mlenergy-data/), which most tools will not recognize. It is better to specify that the mlenergy-data subdirectory should be used.

Suggested change
For other tools, you can download the `skills/` directory and place it in the appropriate skills directory.
For other tools, you can download the `skills/mlenergy-data` directory and place it in the appropriate skills directory.

@jaywonchung jaywonchung deleted the jw-codex-plugin branch May 16, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant