Skip to content

Experiment: Optional minification #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moreati wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Experiment: Optional minification #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mitogen/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
#: Library version as a tuple.
__version__ = (0, 3, 38, 'dev')

import os
MINIFY = os.environ.get('MITOGEN_MINIFY', '1').lower() in ('1', 'true', 'yes')

#: This is :data:`False` in slave contexts. Previously it was used to prevent
#: re-execution of :mod:`__main__` in single file programs, however that now
Expand All @@ -58,8 +60,6 @@
#: IDs ordered from most direct to least direct.
parent_ids = []


import os
_default_profiling = os.environ.get('MITOGEN_PROFILING') is not None
del os

Expand Down
1 change: 1 addition & 0 deletions mitogen/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4180,6 +4180,7 @@ def _setup_package(self):
del sys.modules['__main__']

def _setup_globals(self):
mitogen.MINIFY = self.config['minify']
mitogen.is_master = False
mitogen.__version__ = self.config['version']
mitogen.context_id = self.config['context_id']
Expand Down
2 changes: 2 additions & 0 deletions mitogen/fork.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import threading
import traceback

import mitogen
import mitogen.core
import mitogen.parent
from mitogen.core import b
Expand Down Expand Up @@ -201,6 +202,7 @@ def get_econtext_config(self):
config = super(Connection, self).get_econtext_config()
config['core_src_fd'] = None
config['importer'] = self.options.importer
config['minify'] = mitogen.MINIFY
config['send_ec2'] = False
config['setup_package'] = False
if self.options.on_start:
Expand Down
6 changes: 4 additions & 2 deletions mitogen/master.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ def _get_core_source():
Master version of parent.get_core_source().
"""
source = inspect.getsource(mitogen.core)
return mitogen.minify.minimize_source(source)
if mitogen.MINIFY:
source = mitogen.minify.minimize_source(source)
return source


if mitogen.is_master:
Expand Down Expand Up @@ -1137,7 +1139,7 @@ def _build_tuple(self, fullname):
self._cache[fullname] = tup
return tup

if self.minify_safe_re.search(source):
if mitogen.MINIFY and self.minify_safe_re.search(source):
# If the module contains a magic marker, it's safe to minify.
t0 = mitogen.core.now()
source = mitogen.minify.minimize_source(source).encode('utf-8')
Expand Down
2 changes: 2 additions & 0 deletions mitogen/parent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
# Absolute imports for <2.5.
select = __import__('select')

import mitogen
import mitogen.core
from mitogen.core import b
from mitogen.core import bytes_partition
Expand Down Expand Up @@ -1502,6 +1503,7 @@ def get_econtext_config(self):
'parent_ids': parent_ids,
'context_id': self.context.context_id,
'debug': self.options.debug,
'minify': mitogen.MINIFY,
'profiling': self.options.profiling,
'unidirectional': self.options.unidirectional,
'log_level': get_log_level(),
Expand Down