fix: do not change url for section pages

drf_lint_baseline.json

@@ -1,7 +1,5 @@
 [
   "content_sync/serializers.py:133:21:ORM001",
   "content_sync/serializers.py:54:21:ORM001",
-  "websites/serializers.py:257:23:ORM001",
-  "websites/serializers.py:683:16:ORM001",
-  "websites/serializers.py:700:20:ORM002"
+  "websites/serializers.py:257:23:ORM001"
 ]

pyproject.toml

@@ -177,6 +177,7 @@ ignore = [
     "RUF012",
     "UP007"
 ]
+external = ["ORM001", "ORM002"]
 
 [tool.ruff.lint.pydocstyle]
 convention = "pep257"

websites/serializers.py

@@ -571,7 +571,11 @@ class WebsiteContentDetailSerializer(
     def update(self, instance, validated_data):
         """Update WebsiteContent, handling filename and metadata."""
         title = validated_data.get("title", instance.title)
-        if instance.type == CONTENT_TYPE_PAGE and title:
+        if (
+            instance.type == CONTENT_TYPE_PAGE
+            and title
+            and instance.filename not in constants.CONTENT_FILENAMES_FORBIDDEN
+        ):
             new_filename = slugify(title)
             if instance.filename != new_filename:
                 cur_filename = WebsiteContent.objects.filter(
@@ -680,7 +684,7 @@ def get_content_context(  # noqa: C901, PLR0912
         contents = []
         for website_id, text_ids in lookup.items():
             contents.extend(
-                WebsiteContent.objects.filter(
+                WebsiteContent.objects.filter(  # noqa: ORM001
                     (Q(website__url_path=website_id) | Q(website__name=website_id)),
                     text_id__in=text_ids,
                 )
@@ -697,7 +701,7 @@ def to_representation(self, instance):
             if file_field:
                 result[file_field["name"]] = instance.file.url
 
-        drivefile = instance.drivefile_set.first()
+        drivefile = instance.drivefile_set.first()  # noqa: ORM002
         if drivefile:
             result["gdrive_url"] = DRIVE_FILE_VIEW_URL.format(file_id=drivefile.file_id)
 

websites/serializers_test.py

@@ -905,6 +905,39 @@ def test_update_page_url_on_title_change_parametrized(  # noqa: PLR0913
         assert page.filename == expected_filename
 
 
+@pytest.mark.parametrize(
+    ("initial_filename", "expected_filename"),
+    [
+        ("_index", "_index"),
+        ("original-title", "new-title"),
+    ],
+)
+def test_update_page_url_on_title_change_legacy_index_behavior(
+    enable_websitecontent_signal,
+    initial_filename,
+    expected_filename,
+):
+    """Legacy _index pages skip page url updates; normal pages still proceed with them."""
+    website = WebsiteFactory.create(owner=UserFactory.create())
+    page = WebsiteContentFactory.create(
+        website=website,
+        type=CONTENT_TYPE_PAGE,
+        dirpath="",
+        title="Original Title",
+        filename=initial_filename,
+    )
+
+    serializer = WebsiteContentDetailSerializer(
+        instance=page, data={"title": "New Title"}, partial=True
+    )
+    assert serializer.is_valid(), serializer.errors
+    serializer.save()
+
+    page.refresh_from_db()
+    assert page.filename == expected_filename
+    assert page.title == "New Title"
+
+
 def test_website_content_detail_serializer_syncs_video_relation_files(
     mocker, mocked_website_funcs
 ):