Skip to content

fix(deps): update dependency ckeditor5-math to v36#2518

Open
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/ckeditor5-math-36.x
Open

fix(deps): update dependency ckeditor5-math to v36#2518
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/ckeditor5-math-36.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Apr 23, 2025

This PR contains the following updates:

Package Change Age Confidence
ckeditor5-math 35.4.036.0.2 age confidence

Release Notes

isaul32/ckeditor5-math (ckeditor5-math)

v36.0.2

Compare Source

  • Fix previewClassName (#​86)

v36.0.1

Compare Source

v36.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/ckeditor5-math-36.x branch 19 times, most recently from e9cb182 to b02ff17 Compare April 30, 2025 12:09
@renovate renovate bot force-pushed the renovate/ckeditor5-math-36.x branch 11 times, most recently from 7c3800d to 3343b1f Compare May 9, 2025 09:26
@renovate renovate bot force-pushed the renovate/ckeditor5-math-36.x branch 7 times, most recently from 2c74d56 to 00a6179 Compare June 5, 2025 04:26
@renovate renovate bot force-pushed the renovate/ckeditor5-math-36.x branch 3 times, most recently from 7d0868a to 8d9ed46 Compare June 10, 2025 19:06
@renovate renovate bot force-pushed the renovate/ckeditor5-math-36.x branch 2 times, most recently from 61bda60 to 901370d Compare June 17, 2025 10:57
@renovate renovate bot force-pushed the renovate/ckeditor5-math-36.x branch 4 times, most recently from 2222223 to 8a6a780 Compare June 23, 2025 19:59
Copy link
Copy Markdown
Contributor

@zawan-ila zawan-ila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not build for me. Opening studio on this branch results in an empty page.

I do not think the approach taken towards mocking the versions in the tests is the way forward here. It may get rid of the errors in the tests but who knows what may show up at runtime. Just consider the fact that I am seeing blank pages on this branch even if the CI appears to be green. From the ckeditor docs,

Duplicate modules inevitably lead to runtime errors and increased bundle size

The right approach imo is to update the ckeditor packages together with this, even if that may be a more significant undertaking.

@umar8hassan
Copy link
Copy Markdown
Contributor

Unassigning myself untill we can update CKEditor packages altogether. The fix here masks the underlying problem with mocks, but is causing build issues for the reviewer.

Comment thread package.json
Comment thread package.json
Comment thread package.json
Comment thread package.json
Comment thread package.json
Comment thread package.json
"bootstrap": "4",
"casual": "^1.6.2",
"ckeditor5-math": "35.4.0",
"ckeditor5-math": "36.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update to ckeditor5-math introduces a dependency on CKEditor v36, while other direct dependencies remain on v35, causing two major versions of CKEditor modules to be bundled.
Severity: HIGH

Suggested Fix

Update all direct @ckeditor/* dependencies in package.json from version ^35.4.0 to ^36.0.1 to match the version required by the updated ckeditor5-math package. This will ensure only a single version of the CKEditor modules is bundled.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L72

Potential issue: The update to `ckeditor5-math` to version `36.0.2` introduces
transitive dependencies on `@ckeditor/*` packages at version `^36.0.1`. However, the
project's other direct dependencies on `@ckeditor/*` packages are pinned to `^35.4.0`.
This results in two different major versions of core CKEditor modules being included in
the final bundle. When the application attempts to initialize the editor in the browser,
CKEditor's internal checks will detect these duplicated modules and throw a
`ckeditor-duplicated-modules` runtime error, preventing the editor from loading and
functioning.

Comment thread package.json
"bootstrap": "4",
"casual": "^1.6.2",
"ckeditor5-math": "35.4.0",
"ckeditor5-math": "36.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The package.json lists most CKEditor packages at v35.4.0 but ckeditor5-math at v36.0.2, causing yarn to install conflicting major versions simultaneously.
Severity: MEDIUM

Suggested Fix

To ensure compatibility and stability, all @ckeditor/* packages in package.json should be upgraded to the same major version. Align all packages to ^36.0.1 (or the latest compatible version) to match the ckeditor5-math dependency. After updating, run yarn install and thoroughly test the editor functionality.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L72

Potential issue: The project's `package.json` specifies most CKEditor packages at
version `^35.4.0`, but the `ckeditor5-math` dependency is at `v36.0.2`. This forces the
package manager to install two different major versions of core CKEditor libraries (v35
and v36) side-by-side. According to CKEditor's documentation, mixing major versions is
not supported and can lead to unpredictable runtime issues, such as type mismatches,
plugin registration failures, or having multiple instances of the same editor classes
loaded. While existing tests may pass, this configuration is unstable and violates best
practices, creating a risk of difficult-to-debug errors in production.

Comment thread package.json
"bootstrap": "4",
"casual": "^1.6.2",
"ckeditor5-math": "35.4.0",
"ckeditor5-math": "36.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The ckeditor5-math package at v36.0.2 is incompatible with the other CKEditor packages at v35.4.0, which will likely cause a runtime error.
Severity: HIGH

Suggested Fix

To resolve the version conflict, either downgrade ckeditor5-math to a version compatible with CKEditor 35.4.0, or upgrade all other @ckeditor/* packages to a version compatible with ckeditor5-math@36.0.2, such as ^36.0.1.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L72

Potential issue: The `ckeditor5-math` package was updated to version `36.0.2`, which has
a dependency on CKEditor version `36.x`. However, the other CKEditor packages in the
project remain at version `35.4.0`. This version incompatibility between the math plugin
and the core editor will likely cause a runtime error, such as
`ckeditor-duplicated-modules`, when the math plugin is initialized, preventing it from
functioning.

Comment thread package.json
"bootstrap": "4",
"casual": "^1.6.2",
"ckeditor5-math": "35.4.0",
"ckeditor5-math": "36.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The ckeditor5-math update to v36 creates an incompatible version mix with other v35 CKEditor packages, which will cause a runtime error when the editor initializes.
Severity: HIGH

Suggested Fix

To resolve the incompatibility, all @ckeditor/* packages in package.json should be upgraded to a consistent major version. Since ckeditor5-math is now at v36, all other related packages like @ckeditor/ckeditor5-essentials and @ckeditor/ckeditor5-editor-classic should also be updated to a compatible v36 release.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L72

Potential issue: The update to `ckeditor5-math` to version `36.0.2` while other
`@ckeditor/*` packages remain at `^35.4.0` creates a version conflict. The application's
configuration in `CKEditor.ts` attempts to initialize a v35 `ClassicEditor` with a mix
of plugins from both v35 and v36. According to CKEditor's documentation, major versions
are incompatible. This will cause a runtime error when the `MarkdownEditor` component
renders, preventing the editor from loading for any user interacting with it.

Comment thread package.json
"bootstrap": "4",
"casual": "^1.6.2",
"ckeditor5-math": "35.4.0",
"ckeditor5-math": "36.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating ckeditor5-math to 36.0.2 while other @ckeditor/ckeditor5-* packages remain on ^35.4.0 will cause a runtime crash due to duplicated modules.
Severity: CRITICAL

Suggested Fix

To resolve the version conflict, all @ckeditor/ckeditor5-* packages in package.json should be updated to a compatible v36 version to match the requirements of ckeditor5-math@36.0.2.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L72

Potential issue: The update of `ckeditor5-math` to version `36.0.2` introduces a version
conflict with other `@ckeditor/ckeditor5-*` packages, which are pinned to `^35.4.0`. The
new math package requires core CKEditor dependencies at version `^36.0.1`. This forces
the package manager to install two different versions (v35 and v36) of the same core
CKEditor modules. According to CKEditor's documentation, this leads to a
`ckeditor-duplicated-modules` error at runtime, which will cause the application to
crash when the editor is initialized.

Comment thread package.json
"bootstrap": "4",
"casual": "^1.6.2",
"ckeditor5-math": "35.4.0",
"ckeditor5-math": "36.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The ckeditor5-math package is being upgraded to v36 while other CKEditor dependencies remain on v35. This version mismatch will cause a ckeditor-duplicated-modules error, crashing the editor.
Severity: CRITICAL

Suggested Fix

To resolve the version conflict, all @ckeditor packages listed as dependencies in package.json should be upgraded to a compatible version, likely v36.x, to match the new version of ckeditor5-math.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L72

Potential issue: The update to `ckeditor5-math` to version 36.0.2, while other
`@ckeditor` packages remain on version 35.4.0, will cause a fatal runtime error. The
CKEditor framework is designed to detect when multiple versions of its core modules are
loaded simultaneously. This version mismatch will trigger a
`ckeditor-duplicated-modules` error during initialization, which will prevent the editor
from loading and effectively crash the feature for all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants