Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,31 +7,31 @@
"url": "https://github.com/mitodl/ocw-studio.git"
},
"dependencies": {
"@ckeditor/ckeditor5-adapter-ckfinder": "^35.4.0",
"@ckeditor/ckeditor5-autoformat": "^35.4.0",
"@ckeditor/ckeditor5-basic-styles": "^35.4.0",
"@ckeditor/ckeditor5-block-quote": "^35.4.0",
"@ckeditor/ckeditor5-code-block": "35.4.0",
"@ckeditor/ckeditor5-core": "^35.4.0",
"@ckeditor/ckeditor5-adapter-ckfinder": "^48.0.0",
"@ckeditor/ckeditor5-autoformat": "^48.0.0",
"@ckeditor/ckeditor5-basic-styles": "^48.0.0",
"@ckeditor/ckeditor5-block-quote": "^48.0.0",
"@ckeditor/ckeditor5-code-block": "48.0.0",
"@ckeditor/ckeditor5-core": "^48.0.0",
"@ckeditor/ckeditor5-dev-translations": "^43.0.0",
"@ckeditor/ckeditor5-dev-utils": "^43.0.0",
"@ckeditor/ckeditor5-easy-image": "^35.4.0",
"@ckeditor/ckeditor5-editor-classic": "^35.4.0",
"@ckeditor/ckeditor5-engine": "^35.4.0",
"@ckeditor/ckeditor5-essentials": "^35.4.0",
"@ckeditor/ckeditor5-heading": "^35.4.0",
"@ckeditor/ckeditor5-image": "^35.4.0",
"@ckeditor/ckeditor5-easy-image": "^48.0.0",
"@ckeditor/ckeditor5-editor-classic": "^48.0.0",
"@ckeditor/ckeditor5-engine": "^48.0.0",
"@ckeditor/ckeditor5-essentials": "^48.0.0",
"@ckeditor/ckeditor5-heading": "^48.0.0",
"@ckeditor/ckeditor5-image": "^48.0.0",
"@ckeditor/ckeditor5-inspector": "^5.0.0",
"@ckeditor/ckeditor5-link": "^35.4.0",
"@ckeditor/ckeditor5-list": "^35.4.0",
"@ckeditor/ckeditor5-markdown-gfm": "^35.4.0",
"@ckeditor/ckeditor5-media-embed": "^35.4.0",
"@ckeditor/ckeditor5-paragraph": "^35.4.0",
"@ckeditor/ckeditor5-link": "^48.0.0",
"@ckeditor/ckeditor5-list": "^48.0.0",
"@ckeditor/ckeditor5-markdown-gfm": "^48.0.0",
"@ckeditor/ckeditor5-media-embed": "^48.0.0",
"@ckeditor/ckeditor5-paragraph": "^48.0.0",
"@ckeditor/ckeditor5-react": "^3.0.3",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @ckeditor/ckeditor5-react package at v3.0.3 is incompatible with the upgraded CKEditor v47.0.0 packages, which will likely cause the markdown editor to fail at runtime.
Severity: CRITICAL

Suggested Fix

Upgrade the @ckeditor/ckeditor5-react package to a version compatible with CKEditor v47.0.0, such as v5.x or newer, to ensure the React wrapper can correctly interface with the updated editor engine.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L30

Potential issue: The pull request upgrades core CKEditor packages from v35.4.0 to
v47.0.0 but leaves the React wrapper, `@ckeditor/ckeditor5-react`, at v3.0.3. According
to release information, versions of the React wrapper prior to v5 are not compatible
with CKEditor v46.0.0 and newer due to breaking changes. Since the `CKEditor` component
from this wrapper is used to render the `MarkdownEditor`, this version mismatch will
likely cause the editor component to fail at runtime, breaking a critical UI feature.

"@ckeditor/ckeditor5-table": "^35.4.0",
"@ckeditor/ckeditor5-theme-lark": "^35.4.0",
"@ckeditor/ckeditor5-upload": "^35.4.0",
"@ckeditor/ckeditor5-widget": "^35.4.0",
"@ckeditor/ckeditor5-table": "^48.0.0",
"@ckeditor/ckeditor5-theme-lark": "^47.0.0",
"@ckeditor/ckeditor5-upload": "^48.0.0",
"@ckeditor/ckeditor5-widget": "^48.0.0",
"@dnd-kit/core": "^3.1.1",
"@dnd-kit/sortable": "^4.0.0",
"@reduxjs/toolkit": "^1.8.1",
Expand Down
Loading
Loading